https://bugzilla.redhat.com/show_bug.cgi?id=2112474 --- Comment #18 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- (In reply to Kashyap Chamarthy from comment #14) > (In reply to Miro Hrončok from comment #7) > > Hi, Miro > > I think v2 addresses most of your comments: > > > Note that GPL-2.0-only is the SPDX expression that should now be used in the > > License tag. > > > > > > There are also parts of the spec that are IMHO needlessly obfuscating it: > > > > %global pypi_name qemu.qmp > > %global pkg_name qemu-qmp > > I see your point; but as noted in comment#13, I feel it's a tiny bit cleaner > to define it once at the top. But if you insist to remove them, we could > remove in v3 :-). Okay, Miro convinced me enough on IRC that we can do away with these two macros and fill in the literal values. His main arguments: IMHO in-spec defined macros should only be used for 1) values that happen to change during the package lifetime (e.g. `%version`) 2) values that are configurable in order to 12:54 < mhroncok> 09:33:17> build the package slightly differently (e.g. `%bcond_without tests`) 3) values that make it significantly DRY (e.g. `%summary` or `%_description` or `%build_procedure` of repeated) -- everyhing else is just making it more "clever" for bad reasons -- but this is my personal viewpoint only. @John: if you agree too, in v3, let's please do away with the "pypi_name" and "pkg_name" and fill in the literal values. [...] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2112474 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
