https://bugzilla.redhat.com/show_bug.cgi?id=2112474 Kashyap Chamarthy <kchamart@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mhroncok@redhat.c | |om) --- Comment #14 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #7) Hi, Miro I think v2 addresses most of your comments: > Note that GPL-2.0-only is the SPDX expression that should now be used in the > License tag. > > > There are also parts of the spec that are IMHO needlessly obfuscating it: > > %global pypi_name qemu.qmp > %global pkg_name qemu-qmp I see your point; but as noted in comment#13, I feel it's a tiny bit cleaner to define it once at the top. But if you insist to remove them, we could remove in v3 :-). > %global pypi_version 0.0.1 This is gone in v2. > And parts of the spec that are deprecated and SHOULD not be used: > > %{?python_provide:%python_provide python3-%{pkg_name}} And this too. > I highly recommend starting with > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_empty_spec_file rather than "a file once created by pyp2rpm-3.3.8" Sure. Please let us know if you have any glaring concerns in v2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2112474 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
