https://bugzilla.redhat.com/show_bug.cgi?id=2116087 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Source1: http://www.apache.org/licenses/LICENSE-2.0 > Source2: http://opensource.org/licenses/MIT These are both wrong - they point at HTML pages, not at raw text files. Additionally, the link for MIT doesn't resolve, because that site is now HTTPS only. You should instead file a PR with the upstream project to add the license files (not HTML dumps :), and then you can link the files from your PR. You can look at how must Rust crates (for example, https://github.com/seanmonstar/reqwest) handle this for "inspiration". For example, the "LICENSE-APACHE" and "LICENSE-MIT" file names are pretty standardized across the whole ecosystem. > # Update version deps > # https://github.com/ejmahler/strength_reduce/pull/6 > Patch: rust-strength_reduce-deps.patch You might be interested in rust2rpm's "-p" flag, which automates generation of patches like this one. Please also include a link to the PR that you filed upstream for this. > %files devel > %license LICENSE-2.0 MIT This should be: %files devel %license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT To match what rust2rpm generates if these files are present. It also looks like you uploaded an SRPM file that was already mangled by rpmautospec: > %changelog > * Sat Aug 06 2022 John Doe <packager@xxxxxxxxxxx> 0.2.3-1 > - Uncommitted changes I recommend to use "rpmbuild -bs" to build SRPM files for package review. "fedpkg srpm" will do rpmautospec pre-processing, which is not what you want for the package review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2116087 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
