https://bugzilla.redhat.com/show_bug.cgi?id=2116103 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Unofficial Review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons Attribution-ShareAlike 4.0", "Creative Commons Attribution 4.0", "Unknown or generated", "*No copyright* Creative Commons CC0 1.0", "*No copyright* Free Art License 1.3", "*No copyright* Creative Commons Attribution-ShareAlike". 24 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/f37-backgrounds/2116103-f37-backgrounds/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/xfce4, /usr/share/backgrounds/f37, /usr/share/wallpapers, /usr/share/gnome- background-properties, /usr/share/mate-background-properties [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gnome-background- properties(f28-backgrounds-gnome, desktop-backgrounds-basic, adapta- backgrounds, f32-backgrounds-gnome, solar-backgrounds, f33-backgrounds-gnome, f34-backgrounds-gnome, fedora-workstation- backgrounds, f31-backgrounds-gnome, f29-backgrounds-gnome, f35-backgrounds-gnome, gears-backgrounds, f36-backgrounds-gnome, fedorainfinity-backgrounds, f30-backgrounds-gnome, neon-backgrounds), /usr/share/xfce4(f33-backgrounds-xfce, f36-backgrounds-xfce, f31-backgrounds-xfce, f28-backgrounds-xfce, f29-backgrounds-xfce, f35-backgrounds-xfce, f34-backgrounds-xfce, f32-backgrounds-xfce, f30-backgrounds-xfce), /usr/share/xfce4/backdrops(f35-backgrounds- extras-xfce, f32-backgrounds-extras-xfce, f33-backgrounds-xfce, f31-backgrounds-xfce, f28-backgrounds-xfce, f36-backgrounds-xfce, f29-backgrounds-xfce, f28-backgrounds-extras-xfce, f35-backgrounds- xfce, f30-backgrounds-extras-xfce, f34-backgrounds-xfce, f31-backgrounds-extras-xfce, f32-backgrounds-xfce, f29-backgrounds- extras-xfce, f36-backgrounds-extras-xfce, f30-backgrounds-xfce, f34-backgrounds-extras-xfce, f33-backgrounds-extras-xfce), /usr/share/plasma(f31-backgrounds-kde, f29-backgrounds-kde, f25-backgrounds-kde, f30-backgrounds-kde, f36-backgrounds-kde, f34-backgrounds-kde, f32-backgrounds-kde, kf5-plasma, f26-backgrounds- kde, f33-backgrounds-kde, f35-backgrounds-kde, f27-backgrounds-kde, f28-backgrounds-kde), /usr/share/plasma/desktoptheme(f31-backgrounds- kde, f29-backgrounds-kde, f25-backgrounds-kde, f30-backgrounds-kde, f36-backgrounds-kde, f34-backgrounds-kde, f32-backgrounds-kde, kf5-plasma, f26-backgrounds-kde, f33-backgrounds-kde, f35-backgrounds- kde, f27-backgrounds-kde, f28-backgrounds-kde, plasma-desktop), /usr/share/mate-background-properties(f28-backgrounds-mate, f32-backgrounds-mate, desktop-backgrounds-basic, adapta-backgrounds, f29-backgrounds-mate, mate-backgrounds, f30-backgrounds-mate, fedorainfinity-backgrounds, f33-backgrounds-mate, f35-backgrounds- mate, f34-backgrounds-mate, f31-backgrounds-mate, f36-backgrounds- mate) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in f37-backgrounds-base , f37-backgrounds-gnome , f37-backgrounds-kde , f37-backgrounds-mate , f37-backgrounds-xfce , f37-backgrounds-extras- base , f37-backgrounds-extras-gnome , f37-backgrounds-extras-mate , f37-backgrounds-extras-kde , f37-backgrounds-extras-xfce [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/fedoradesign/backgrounds/releases/download/v37.0.0/f37-backgr ounds-37.0.0.tar.xz : CHECKSUM(SHA256) this package : 34c8b4b23eb224c4c01bf7e4015a1da850f5228627 bd3670b2dde3b645c1b9a6 CHECKSUM(SHA256) upstream package : 34c8b4b23eb224c4c01bf7e4015a1da850f5228627 bd3670b2dde3b645c1b9a6 Requires -------- f37-backgrounds (rpmlib, GLIBC filtered): f37-backgrounds-gnome f37-backgrounds-kde f37-backgrounds-mate f37-backgrounds-xfce f37-backgrounds-base (rpmlib, GLIBC filtered): f37-backgrounds-gnome (rpmlib, GLIBC filtered): f37-backgrounds-base f37-backgrounds-kde (rpmlib, GLIBC filtered): f37-backgrounds-base kde-filesystem f37-backgrounds-mate (rpmlib, GLIBC filtered): f37-backgrounds-base f37-backgrounds-xfce (rpmlib, GLIBC filtered): f37-backgrounds-base xfdesktop f37-backgrounds-extras-base (rpmlib, GLIBC filtered): f37-backgrounds-extras-gnome (rpmlib, GLIBC filtered): f37-backgrounds-extras-base f37-backgrounds-extras-mate (rpmlib, GLIBC filtered): f37-backgrounds-extras-base f37-backgrounds-extras-kde (rpmlib, GLIBC filtered): f37-backgrounds-extras-base f37-backgrounds-extras-xfce (rpmlib, GLIBC filtered): f37-backgrounds-extras-base Provides -------- f37-backgrounds: f37-backgrounds f37-backgrounds-base: f37-backgrounds-base f37-backgrounds-gnome: f37-backgrounds-gnome f37-backgrounds-kde: f37-backgrounds-kde f37-backgrounds-mate: f37-backgrounds-mate f37-backgrounds-xfce: f37-backgrounds-xfce f37-backgrounds-extras-base: f37-backgrounds-extras-base f37-backgrounds-extras-gnome: f37-backgrounds-extras-gnome f37-backgrounds-extras-mate: f37-backgrounds-extras-mate f37-backgrounds-extras-kde: f37-backgrounds-extras-kde f37-backgrounds-extras-xfce: f37-backgrounds-extras-xfce Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2116103 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, R, Python, Haskell, SugarActivity, PHP, Ocaml, Perl, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint f37-backgrounds-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.7 s $ rpmlint f37-backgrounds-37.0.0-1.fc37.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.5 s $ rpmlint f37-backgrounds-base-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-base.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.5 s $ rpmlint f37-backgrounds-extras-base-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-extras-base.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.7 s $ rpmlint f37-backgrounds-extras-gnome-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-extras-gnome.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.5 s $ rpmlint f37-backgrounds-extras-kde-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-extras-kde.noarch: W: no-documentation f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1024x600.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1024x768.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1152x720.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1152x864.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1200x900.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1280x1024.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1280x720.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1280x768.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1280x800.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1280x960.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1366x768.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1440x1080.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1440x900.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1600x1200.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1600x1280.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1680x1050.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1920x1080.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1920x1200.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/1920x1440.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/2048x1536.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/2160x1440.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/2304x1440.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/2560x1440.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/2560x1600.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/2960x1440.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/3000x2000.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/3200x1800.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/3440x1440.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/3840x2160.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/640x480.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/800x480.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_dark-blue/contents/images/800x600.png ../../../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1024x600.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1024x768.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1152x720.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1152x864.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1200x900.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1280x1024.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1280x720.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1280x768.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1280x800.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1280x960.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1366x768.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1440x1080.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1440x900.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1600x1200.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1600x1280.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1680x1050.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1920x1080.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1920x1200.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/1920x1440.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/2048x1536.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/2160x1440.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/2304x1440.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/2560x1440.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/2560x1600.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/2960x1440.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/3000x2000.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/3200x1800.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/3440x1440.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/3840x2160.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/640x480.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/800x480.png ../../../../backgrounds/f37/extras/light-blue.png f37-backgrounds-extras-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37_light-blue/contents/images/800x600.png ../../../../backgrounds/f37/extras/light-blue.png 1 packages and 0 specfiles checked; 0 errors, 65 warnings, 0 badness; has taken 0.6 s $ rpmlint f37-backgrounds-extras-mate-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-extras-mate.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint f37-backgrounds-extras-xfce-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-extras-xfce.noarch: W: no-documentation f37-backgrounds-extras-xfce.noarch: W: dangling-symlink /usr/share/xfce4/backdrops/f37-02-night.png /usr/share/backgrounds/f37/default/f37-02-night.png f37-backgrounds-extras-xfce.noarch: W: dangling-symlink /usr/share/xfce4/backdrops/f37.png /usr/share/backgrounds/f37/default/f37-01-day.png f37-backgrounds-extras-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f37-dark-blue.png ../../backgrounds/f37/extras/dark-blue.png f37-backgrounds-extras-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f37-light-blue.png ../../backgrounds/f37/extras/light-blue.png 1 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.2 s $ rpmlint f37-backgrounds-gnome-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-gnome.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint f37-backgrounds-kde-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-kde.noarch: W: no-documentation f37-backgrounds-kde.noarch: W: files-duplicate /usr/share/wallpapers/F37/metadata.desktop /usr/share/plasma/desktoptheme/F37/metadata.desktop f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1024x600.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1024x768.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1152x720.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1152x864.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1200x900.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1280x1024.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1280x720.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1280x768.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1280x800.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1280x960.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1366x768.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1440x1080.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1440x900.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1600x1200.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1600x1280.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1680x1050.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1920x1080.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1920x1200.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1920x1280.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/1920x1440.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/2048x1536.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/2160x1440.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/2304x1440.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/2560x1440.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/2560x1600.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/2960x1440.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/3000x2000.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/3200x1800.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/3440x1440.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/3840x2160.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/640x480.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/800x480.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images/800x600.png ../../../../backgrounds/f37/default/f37.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1024x600.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1024x768.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1152x720.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1152x864.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1200x900.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1280x1024.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1280x720.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1280x768.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1280x800.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1280x960.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1366x768.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1440x1080.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1440x900.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1600x1200.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1600x1280.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1680x1050.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1920x1080.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1920x1200.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1920x1280.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/1920x1440.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/2048x1536.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/2160x1440.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/2304x1440.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/2560x1440.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/2560x1600.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/2960x1440.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/3000x2000.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/3200x1800.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/3440x1440.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/3840x2160.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/640x480.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/800x480.png ../../../../backgrounds/f37/default/f37-02-night.png f37-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F37/contents/images_dark/800x600.png ../../../../backgrounds/f37/default/f37-02-night.png 1 packages and 0 specfiles checked; 0 errors, 68 warnings, 0 badness; has taken 0.4 s $ rpmlint f37-backgrounds-mate-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-mate.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s $ rpmlint f37-backgrounds-xfce-37.0.0-1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 f37-backgrounds-xfce.noarch: W: no-documentation f37-backgrounds-xfce.noarch: W: dangling-symlink /usr/share/xfce4/backdrops/f37.png /usr/share/backgrounds/f37/default/f37-01-day.png 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.2 s Comments: a) In the main repository, should https://github.com/fedoradesign/backgrounds/blob/main/extras/generate-files.rb be removed as it seems Makefiles are now used? b) Spec file indicates CC-BY and CC-BY-SA for Extras-Base, but seems that only CC-BY-SA is required for the images? c) Minor comment since the main content of the package is the image files, but should the Makefile, ruby file and xml files have license information? d) Minor comment, can image licensing information be added to the EXIF metadata, see for example https://www.bettertechtips.com/linux/view-exif-data-linux/ e) For KDE images, could ImageMagick be used to resize the image rather than linking to the reference image? This could be done in the makefile and ImageMagick added as a build dependency -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2116103 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
