https://bugzilla.redhat.com/show_bug.cgi?id=2113870 --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Jitka Plesnikova from comment #2) > Source files are ok > TODO: perl-IO-Compress-Brotli.rpmlintrc can be removed. It isn't necessary > to add it into rpm. Just add it to git repository. Source0: https://cpan.metacpan.org/authors/id/M/MG/MGV/IO-Compress-Brotli-%{version}.tar.gz -Source1: perl-IO-Compress-Brotli.rpmlintrc Ok > FIX: Update the text of summary "Read and write Brotli buffers/streams" -Summary: Write Brotli buffers/streams +Summary: Brotli compression library for perl Ok. > FIX: Remove 'Group' tag. 'Group' should not be used. -Group: Development/Libraries Ok. > FIX: Remove %defattr from %files section - it is needed only for EPEL =< 6 > TODO: I think 'META.json' could be removed from %doc. It does not contain > any useful information. -%defattr(-,root,root,-) -%doc Changes META.json README +%doc Changes README Ok. FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages (perl-IO-Compress-Brotli.spec:5). Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct the last 'FIX' item and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2113870 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
