[Bug 2111647] Review Request: perl-HTTP-Easy - HTTP helpers for Perl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2111647

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |requires_doc_text?          |



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Changes in the spec file:

--- perl-HTTP-Easy.spec.old     2022-07-27 19:56:52.000000000 +0200
+++ perl-HTTP-Easy.spec 2022-08-04 15:19:15.000000000 +0200
@@ -1,37 +1,40 @@
 Name:           perl-HTTP-Easy
 Version:        0.02
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        HTTP helpers for Perl
-License:        GPL+ or Artistic
+License:        GPL-1.0-or-later OR Artistic-1.0-Perl
 URL:            https://metacpan.org/dist/HTTP-Easy
 Source0:       
https://cpan.metacpan.org/authors/id/M/MO/MONS/HTTP-Easy-%{version}.tar.gz

 BuildArch:      noarch

+BuildRequires:  coreutils
 BuildRequires:  make
 BuildRequires:  perl-generators
 BuildRequires:  perl-interpreter
 BuildRequires:  perl(Exporter)
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires:  perl(Scalar::Util)
 BuildRequires:  perl(Time::Local)
 BuildRequires:  perl(base)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
+BuildRequires:  perl(:VERSION) >= 5.8.8
 # tests
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(lib::abs)
 BuildRequires:  perl(URI)

-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))

 %description
-Set of useful helpers for HTTP work with perl.
+Set of useful helpers for HTTP work with Perl.

 %prep
 %setup -q -n HTTP-Easy-%{version}

 %build
+unset AUTHOR
 perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
 %make_build

@@ -48,5 +51,8 @@
 %{_mandir}/man3/*

 %changelog
+* Thu Aug  4 2022 Yanko Kaneti <yaneti@xxxxxxxxxxx> - 0.02-2
+- Address review issues (#2111647)
+
 * Wed Jul 27 2022 Yanko Kaneti <yaneti@xxxxxxxxxxx> - 0.02-1
 - First attempt


$ rpmlint perl-HTTP-Easy.spec ../SRPMS/perl-HTTP-Easy-0.02-2.fc37.src.rpm
../RPMS/noarch/perl-HTTP-Easy-0.02-2.fc37.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-HTTP-Easy.noarch: W: invalid-license GPL-1.0-or-later
perl-HTTP-Easy.noarch: W: invalid-license Artistic-1.0-Perl
perl-HTTP-Easy.src: W: invalid-license GPL-1.0-or-later
perl-HTTP-Easy.src: W: invalid-license Artistic-1.0-Perl
========= 2 packages and 1 specfiles checked; 0 errors, 4 warnings, 0 badness;
has taken 0.2 s ========
rpmlint is Ok.

The package builds in F37
(https://koji.fedoraproject.org/koji/taskinfo?taskID=90466047). Ok.

Resolution: Package APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2111647
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux