[Bug 2115150] Review Request: cherrytree - Hierarchical note taking application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2115150

Jonathan Wright <jonathan@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> ---
I think some modernizing is in order.

> License:        MPLv2.0 and MPLv1.1 and BSD and GPLv2+ and GPLv3+ and LGPLv2+ and AFL and ASL 2.0

This needs to be updated to SPDX.  ref
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names

> %patch01 -p1
> %patch02 -p1
> %patch03 -p1
> %patch09 -p1
> %patch10 -p1
> 
> %patch12 -p1
> %patch13 -p1
> %patch14 -p1
> %patch15 -p1
> %patch16 -p1
> %patch17 -p1
> %patch18 -p1

> %patch20 -p1
> # Fixes for ppc64 and s390x, there is no need to keep it in ifarch here since mozilla tests support ifarch conditions
> %patch21 -p1

I wonder if you could replace all of this by using %autosetup?

> # Prefer GCC for now
> export CC=gcc
> export CXX=g++

This is the default anyway.

> export CFLAGS="%{optflags}"
> export CXXFLAGS="$CFLAGS"
> export LINKFLAGS="%{?build_ldflags}"
> export PYTHON="%{python3}"

I don't think any of this is necessary either.

That's all I have for now.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2115150
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux