https://bugzilla.redhat.com/show_bug.cgi?id=2115068 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: 1) Consider using the modern Python guidelines instead of the deprecated old ones. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ 2) %global pypi_name pytest-click %global pypi_version 1.1.0 I think that defining those macros is redundant and it IMHO makes the specfile harder to read. But that's just my opinion. 3) Source0: https://files.pythonhosted.org/packages/source/p/%{pypi_name}/pytest_click-%{pypi_version}.tar.gz Consider removing the redundant zero. Consider using %{pypi_source pytest_click} instead of the hardcoded URL. 4) %{?python_provide:%python_provide python3-%{pypi_name}} This is deprecated and SHOULD NOT be used. See the note at the bottom of https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_the_py_provides_macro 5) Requires: python3dist(click) >= 6 Requires: python3dist(pytest) >= 5 Requires: python3dist(setuptools) Manual requirements should not be needed. This already requires: python3.11dist(click) >= 6 python3.11dist(pytest) >= 5 And I see no reason to require setuptools on runtime. 6) # Remove bundled egg-info rm -rf %{pypi_name}.egg-info Why is this here? Is it needed for anything? Is there a "bundled egg-info"? What is bundled in in? 7) %{python3_sitelib}/pytest_click %{python3_sitelib}/pytest_click-%{pypi_version}-py%{python3_version}.egg-info Consider adding trailing slahes to ensure those are directories. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2115068 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
