https://bugzilla.redhat.com/show_bug.cgi?id=2113870 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jplesnik@xxxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source files are ok TODO: perl-IO-Compress-Brotli.rpmlintrc can be removed. It isn't necessary to add it into rpm. Just add it to git repository. URL and Source0 are ok Summary FIX: Update the text of summary "Read and write Brotli buffers/streams" FIX: Remove 'Group' tag. 'Group' should not be used. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections License is ok Description is ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-IO-Compress-Brotli-0.004001-3.fc37.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libbrotlidec.so.1()(64bit) 1 libbrotlienc.so.1()(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.36()(64bit) 1 perl(bytes) 1 perl(Exporter) 1 perl(File::Slurper) 1 perl(Getopt::Long) 1 perl(IO::Compress::Brotli) 1 perl(IO::Uncompress::Brotli) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(parent) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) 1 /usr/bin/perl Binary requires are Ok. $ rpm -qp --provides perl-IO-Compress-Brotli-0.004001-3.fc37.x86_64.rpm | sort | uniq -c 1 perl(IO::Compress::Brotli) = 0.004001 1 perl-IO-Compress-Brotli = 0.004001-3.fc37 1 perl-IO-Compress-Brotli(x86-64) = 0.004001-3.fc37 1 perl(IO::Uncompress::Brotli) = 0.004001 Binary provides are Ok. $ rpmlint -r perl-IO-Compress-Brotli.rpmlintrc ./perl-IO-Compress-Brotli* ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('perl-IO-Compress-Brotli.rpmlintrc')] checks: 32, packages: 4 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint is ok FIX: Remove %defattr from %files section - it is needed only for EPEL =< 6 TODO: I think 'META.json' could be removed from %doc. It does not contain any useful information. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2113870 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
