https://bugzilla.redhat.com/show_bug.cgi?id=2042701 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fedora@xxxxxxxxxx | |) | --- Comment #8 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Comment: 0 → updated Please post a comment with new links instead of editing the original bug. > Source1: https://raw.githubusercontent.com/vlang/vc/1521ffb810f89d247113a1f3381b176817bb88ba/v.c According to the commit messages, this "vc" commit corresponds to the "weekly.2022.30" tag in the main "v" repo, not "0.3". You should either switch to using the commit that matches the "0.3" tag, or add snapshot info to the Release: field. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > %build > tar xvfz %{SOURCE0} -C %{_builddir}/ Why not just: > %prep > %autosetup -n v-%{release_build} That will unpack the archive for you and cd into "v-%{release_build}". > $CC -std=gnu11 %{optflags} -w -I %{_builddir}/v-%{release_build}/thirdparty/stdatomic/nix -o %{_builddir}/v-%{release_build}/v1 %{_builddir}/v.c -lm -lpthread I believe this should include "%{build_ldflags}" as well. > install -m 0755 -p %{_builddir}/v-%{release_build}/v %{buildroot}%{_bindir}/v If you use %autosetup, then the scripts in %build and %install will start with "%{_builddir}/v-%{release_build}" as their working directory, so you won't have to specify the full path everywhere. > %files > %{_datadir}/%{NAME}/examples/* > %{_datadir}/%{NAME}/tutorials/* This will cause the package to own the files inside the directories, but not the directories themselves. You can just use "%{_datadir}/%{name}/" here. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/#_common_mistakes -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2042701 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
