https://bugzilla.redhat.com/show_bug.cgi?id=2111978 --- Comment #4 from Kalev Lember <klember@xxxxxxxxxx> --- (In reply to Jonathan Wright from comment #2) > I think you need "Requires: hicolor-icon-theme" so the icon directory > structure retains proper package ownership. Thanks! Fixed. Spec URL: https://kalev.fedorapeople.org/libpanel.spec SRPM URL: https://kalev.fedorapeople.org/libpanel-1.0~alpha-2.fc37.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90200176 (In reply to Jonathan Wright from comment #3) > I would also adjust the source to use variables wherever possible: > > Source0: > https://download.gnome.org/sources/%{name}/1.0/%{name}-%{tarball_version}. > tar.xz I disagree with this one, because %{name} semantically means the package name and not necessarily the upstream tarball name. They happen to match here but if we had instead called the package e.g. libpanel1 (which can easily happen in the future if we need to make a compat package for a future API bump) then they no longer match up and someone needs to go and remove all the %{name} substitutions from urls and things where they then would be wrong. I have used %{name} where it semantically means the package name, e.g. "Requires: %{name}%{?_isa} = %{version}-%{release}" that the -devel package has. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2111978 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
