[Bug 2111672] Review Request: python-scantree - Flexible recursive directory iterator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2111672



--- Comment #3 from Major Hayden 🤠 <mhayden@xxxxxxxxxx> ---
(In reply to Scott K Logan from comment #2)
> Thanks for the really fast review!
> 
> I converted the package to use pyproject-rpm-macros:
> Spec URL:
> https://cottsay.fedorapeople.org/python-scantree/python-scantree.spec

Great work!

> One question: the package installs a LICENSE file to the dist-info
> directory. Should I omit '%license LICENSE' in that case?

You can leave the %license line there if you want to be extra explicit, but
pyproject-rpm-macros will pick up that license file for you automatically. I
usually leave it out to keep the spec a bit shorter.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2111672
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux