Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flam3 - Programs to generate and render cosmic recursive fractal flames https://bugzilla.redhat.com/show_bug.cgi?id=417711 ------- Additional Comments From fedora@xxxxxxxxxxxxxx 2007-12-12 17:14 EST ------- (Unofficial: I can neither approve your package or sponsor you, but there are some things you need to look at before a real reviewer gets here...) I'm only able to test building the package for i386, but besides some warnings, it seems to work ok. You should probably drop kernel from the requires. I could be wrong but it looks like it might prevent users of kernel-xen from installing your package. Besides, it ought to be a reasonable assumption to say all users will have a kernel installed. ;-) Also, rpmlint says: flam3.i386: E: explicit-lib-dependency libjpeg flam3.i386: E: explicit-lib-dependency libpng flam3.i386: E: explicit-lib-dependency libxml2 which indicates that rpm will find these dependencies on its own and that you should not include them in your requires. This being the case, it's probably also safe to remove zlib from the requires since it's a dependency of libpng. flam3.i386: W: devel-file-in-non-devel-package /usr/lib/pkgconfig/flam3.pc flam3.i386: W: devel-file-in-non-devel-package /usr/include/flam3.h flam3.i386: W: devel-file-in-non-devel-package /usr/lib/libflam3.a This indicates that you need to move these files into subpackages. Header files (and usually pkgconfig files) must be *-devel packages and static libs must be in *-static packages. (Take a look at zlib or similar http://cvs.fedoraproject.org/viewcvs/rpms/zlib/devel/ if you need an example.) Packages containing pkgconfig files must also list pkgconfig as a dependency. flam3.i386: W: no-documentation There is nothing in your %doc section in the SPEC. The source package includes the text of the licence in its own file "COPYING" so it must be included in this section and will resolve the error. flam3-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/flam3-2.7.6/png.c This file shouldn't be executable. After making these changes, don't forget to increment the release number. This is my first real review. I hope I've been helpful. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review