Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: argyllcms - ICC compatible color management system https://bugzilla.redhat.com/show_bug.cgi?id=421921 nicolas.mailhot@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Flag|needinfo?(nicolas.mailhot@la| |poste.net) | ------- Additional Comments From nicolas.mailhot@xxxxxxxxxxx 2007-12-12 15:47 EST ------- - VERIFY - Legal should verify text of the cgats/License.txt & icc/License.txt BSD-like files Those bits are not linked against anything else, and not exported by Argyll since it's all statically linked. So the only compatibility problem we may have would be between the GPLv3 and Argyll, and since their common author judges it's ok, exposing those licenses to users seems rather useless to me. But for legal to judge. The bits I'm actually worried against are the GPLv2 files in spectro linked against all this GPLv3 codebase, since they are *not* written by the same author. It's rather unclear to me if they're GPLv2+ and Graeme W. Gill is pedantic in exposing their license, or not. MUST: The License field in the package spec file must match the actual license. - FAIL - Should be 'GPLv3+ and BSD-like' instead of merely 'GPLv3+' If you want but BSD-like is not a valid license - FAIL - %doc should include the cgats/License.txt and icc/License.txt files too OK - PASS - recommend changing to use an explicit %dir My preference usually too, must have been exposed to too many line counters to not have done it this way from the beginning - PASS For the icclink clash I recommend changing 'argyllcms-icclink' to instead be 'icclink-argyll' so it tab-completes under shell Good idea - FAIL Needs 2 aforementioned buffer overflow patches More patches like that welcome :p - the %changelog section contains a number of unusual UTF-8 characters SPECS are UTF-8, and changelog in particular can contain UTF-8 names (which is the case there), so asciifying presents no interest Thanks a lot for this timely review! New files at the same place as previously -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review