https://bugzilla.redhat.com/show_bug.cgi?id=2110130 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gotmax@e.email Doc Type|--- |If docs needed, set a value --- Comment #2 from Maxwell G <gotmax@e.email> --- > %{_bindir}/* Globs like this should not be used, according to the packaging guidelines. Please explicitly list the paths. You can use bash style parameter expansion (e.g. `%{_bindir}/{bin1,bin2,bin3}`) if you'd like. > # Upstream license specification: BSD-3-Clause > License: BSD You might want to switch this to use the SPDX identifier. You should also include PATENTS in %license or %doc. --- I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct NOTE: The README says: > Database entries available at https://vuln.go.dev are distributed under the terms of the [CC-BY 4.0](https://creativecommons.org/licenses/by/4.0/) license. These files don't appear to be included in the package, however. - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [!] The package complies with the Packaging Guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2110130 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
