https://bugzilla.redhat.com/show_bug.cgi?id=1997994 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |code@xxxxxxxxxxxxxxxxxx --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Instead of License: MIT you will need something like # The entire source is MIT except: # - src/oidc-prompt/mustache/ is ISC; it is used in oidc-prompt, which is # in the -desktop subpackage # - src/oidc-gen/qr.c is GPLv2+; it is ussed in oidc-gen, which is in the # -cli package License: MIT and then %package cli […] License: MIT and GPLv2+ […] %package desktop […] License: MIT and ISC - The ISC license requires that a copy of its text must be included. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text for options. Or figure out how to unbundle mustach. - Even though they are not installed, you should remove pre-compiled Windows binaries in %prep: # Remove pre-compiled Windows binaries find . -type f \( -name '*.exe' -o -name '*.dll' \) -print -delete - There is nothing that owns /etc/X11/Xsession.d in the distribution, but the “desktop” subpackage installs files there. First, verify that the file you install there is actually doing something useful. Then, consider which of the cases in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership best applies. Maybe this package needs to co-own the directory, or maybe there is some other package that should be a dependency and should get a PR to create and own it. - Nobody owns /etc/oidc-agent. To %files cli, add: %dir %{_sysconfdir}/oidc-agent - The use of, e.g., %defattr(-,root,root,-) is unnecessary and discouraged. Is this a SUSE-ism? See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions - src/oidc-prompt/html/static/css/lib/bootstrap.min.css is Bootswatch https://github.com/thomaspark/bootswatch. According to https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/#_css, it cannot be included unless you compile it from the SCSS sources in the package build. - There are several bundled libraries: - lib/cJSON/ is cJSON, https://github.com/DaveGamble/cJSON, https://src.fedoraproject.org/rpms/cjson/ - lib/list/ is clibs/list, https://github.com/clibs/list - src/oidc-prompt/mustache is https://gitlab.com/jobol/mustach Each must be handled according to https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling: you must unbundle them or satisfy certain requirements for bundling. The Makefile variables USE_CJSON_SO and USE_LIST_SO may be relevant. - For the patch oidc-agent-desktop-terminal.patch, you should add a comment about the upstream status, such as a link to an upstream bug tracker or an explanation of why the patch must be downstream-only. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment - You should not use the BuildRoot tag in the spec file: BuildRoot: %{_tmppath}/%{name} - The install rules in the Makefile don’t appear to preserve timestamps. I believe that sed -r -i 's/\b(install )([-\$])/\1-p \2/' Makefile in %prep would resolve this; I have tested that the sed invocation does what I expect, but I haven’t tested a build with the patched Makefile. This would be considered a patch and should be offered upstream (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_patch_guidelines). - According to rpmlint: oidc-agent-desktop.x86_64: W: position-independent-executable-suggested /usr/bin/oidc-prompt at least oidc-prompt is compiled without PIE. Please investigate. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_pie - The base package (oidc-agent) appears to contain only the license and README.md, and none of the other packages depend on it. The README.md is also already installed with liboidc-agent4. In my opinion, the existence of this oidc-agent binary RPM is useless and confusing. I strongly suggest removing the %files section for the base package entirely so that no oidc-agent binary RPM is built. - The package links against libsodium-static, but in general, Executables and libraries SHOULD NOT be linked statically against libraries which come from other packages. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables If you cannot use the libsodium shared library, please add a comment to the spec file justifying why static linking is required. ===== Notes (no change required) ===== - If you like, you can drop %license LICENSE from subpackages other than liboidc-agent4, since the others depend on it (directly or indirectly). https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing - Co-ownership of %{_datadir}/bash-completion/completions/ is acceptable, but this directory is owned by the “filesystem” package, so it would be better to just own the files that this package installs there. - A better source archive URL would be: Source0: https://github.com/indigo-dc/oidc-agent/archive/v%{version}/oidc-agent-%{version}.tar.gz or Source0: %{url}/archive/v%{version}/oidc-agent-%{version}.tar.gz That way, the tarball would be easier to identify and its name would match the name of the directory it contains. - I have not attempted to evaluate whether any systemd unit files are required. - You can ignore all of the rpmlint diagnostics from debuginfo packages. The following are not serious problems: liboidc-agent-devel.x86_64: W: summary-not-capitalized oidc-agent library development files liboidc-agent4.x86_64: W: summary-not-capitalized oidc-agent library although you could consider rewriting as, e.g., “Library for oidc-agent” - In general, I question whether maintaining a single-source spec file for Fedora and other RPM-based distributions will be a practical endeavor, since the packaging guidelines differ so significantly. Note that even if you choose to do this (and it is possible, with enough conditionals), the Fedora spec file will diverge due to: - Mass rebuilds (which bump the release and add a changelog entry) - Occasional mass spec file changes enacted by provenpackagers - You should not use %{__rm} and %{__sed}; prefer rm and sed instead. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "GNU Lesser General Public License v2.1 or later", "ISC License", "*No copyright* [generated file]", "MIT License [generated file]", "*No copyright* ISC License". 535 files have unknown license. Detailed output of licensecheck in /home/reviewer/oidc-agent/review- oidc-agent/licensecheck.txt See note in Issues [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/X11/Xsession.d, /etc/oidc-agent [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/X11/Xsession.d, /etc/oidc-agent [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/bash- completion/completions(tealdeer, poetry, xss-lock, gammu, devscripts- checkbashisms, doctl, python3-catkin_tools, smc-tools, unar, gpaste, mt-st, task, tracker, xca, git-delta, just, minipro, driverctl, maven, coccinelle-bash-completion, gh, git-core, dosbox-staging, mdbtools, hstr, kmod, nnn, lightdm, lxi-tools, glib2, yadifa-tools, flameshot, swaylock, wlogout, pcp, alacritty, environment-modules, cowsay, httpie, source-highlight, timew, tldr, fedora-update-feedback, kompose, packit, rpmdevtools, lmms, awscli, vagrant, skopeo, cobbler, python-django-bash-completion, libnbd-bash-completion, golang-github- tdewolff-minify, repo, composer, python3-tqdm, dnf, beaker-client, filesystem, calibre, osslsigncode, firewalld, playerctl, devscripts, toolbox, mtr, reprepro, monotone, pbuilder, docker-compose, lastpass- cli, libqmi-utils, zeitgeist, libappstream-glib, zypper, datamash, fd- find, pdfgrep, yadifa, bubblewrap, breezy, guestfs-tools-bash- completion, restic, darcs, hyperfine, dconf-editor, docopt, ethtool, dub, tio, switchtec, eg, dotnet-host, nitrokey-app, stress-ng, python3-trezor, ripgrep, GMT-common, swayidle, opensc, python3-streamlink, hashcat, libmbim-utils, nbdkit-bash-completion, exa, firejail, cpu-x, calf, licensecheck, falkon, chocolate-doom, fedpkg, lxc, chatty, gopass, buildah, stratis-cli, rubygem-ronn-ng, clevis, python3-pip, hcloud, sway, ffsend, exercism, ModemManager, bash-completion, rpmspectool, croc, nordugrid-arc-client, tig, vultr- cli, etckeeper, libguestfs-bash-completion, azure-cli, subversion, skim, bodhi-cli, ldc, flatpak, linode-cli, vcsh, zola) [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [?]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines (except as noted) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name} See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. There is a license file for the MIT license, but you must provide one for mustach’s ISC license if you cannot unbundle it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- agent-cli , liboidc-agent4 , liboidc-agent-devel , oidc-agent-desktop Appropriate fully-versioned dependencies appear to be present. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. Upstream provides no tests, but the mandatory desktop-file-validate invocation is present. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/indigo-dc/oidc-agent/archive/refs/tags/v4.3.2.tar.gz : CHECKSUM(SHA256) this package : 8f18afa7a066e7a781d3c239afd183115205edacfd58806906c9f48f24bfe2b0 CHECKSUM(SHA256) upstream package : 8f18afa7a066e7a781d3c239afd183115205edacfd58806906c9f48f24bfe2b0 Requires -------- oidc-agent (rpmlib, GLIBC filtered): oidc-agent-desktop(x86-64) oidc-agent-cli (rpmlib, GLIBC filtered): /usr/bin/bash config(oidc-agent-cli) jq libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libmicrohttpd.so.12()(64bit) liboidc-agent4(x86-64) libqrencode.so.4()(64bit) libsecret-1.so.0()(64bit) libsodium.so.23()(64bit) rtld(GNU_HASH) liboidc-agent4 (rpmlib, GLIBC filtered): libc.so.6()(64bit) libsodium.so.23()(64bit) rtld(GNU_HASH) liboidc-agent-devel (rpmlib, GLIBC filtered): liboidc-agent.so.4()(64bit) liboidc-agent4(x86-64) oidc-agent-desktop (rpmlib, GLIBC filtered): config(oidc-agent-desktop) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libharfbuzz.so.0()(64bit) libjavascriptcoregtk-4.0.so.18()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libsodium.so.23()(64bit) libsoup-2.4.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwebkit2gtk-4.0.so.37()(64bit) libz.so.1()(64bit) oidc-agent-cli(x86-64) rtld(GNU_HASH) webkitgtk4 xterm oidc-agent-debuginfo (rpmlib, GLIBC filtered): oidc-agent-debugsource (rpmlib, GLIBC filtered): Provides -------- oidc-agent: oidc-agent oidc-agent(x86-64) oidc-agent-cli: config(oidc-agent-cli) oidc-agent-cli oidc-agent-cli(x86-64) liboidc-agent4: liboidc-agent.so.4()(64bit) liboidc-agent4 liboidc-agent4(x86-64) liboidc-agent-devel: liboidc-agent-devel liboidc-agent-devel(x86-64) oidc-agent-desktop: application() application(oidc-gen.desktop) config(oidc-agent-desktop) mimehandler(x-scheme-handler/edu.kit.data.oidc-agent) oidc-agent-desktop oidc-agent-desktop(x86-64) oidc-agent-debuginfo: oidc-agent-debuginfo oidc-agent-debuginfo(x86-64) oidc-agent-debugsource: oidc-agent-debugsource oidc-agent-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -n oidc-agent Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, R, Haskell, SugarActivity, PHP, Ocaml, fonts, Python, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 11 liboidc-agent4-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/liboidc-agent.so.4.3.2-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oidc-add-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oidc-agent-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oidc-gen-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oidc-token-4.3.2-1.fc37.x86_64.debug oidc-agent-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/oidc-agent-4.3.2-1.fc37.x86_64 oidc-agent-desktop-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/oidc-prompt-4.3.2-1.fc37.x86_64.debug liboidc-agent-devel.x86_64: W: summary-not-capitalized oidc-agent library development files liboidc-agent4.x86_64: W: summary-not-capitalized oidc-agent library oidc-agent-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/oidc-agent-4.3.2-1.fc37.x86_64 oidc-agent-desktop-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/usr/bin/oidc-prompt-4.3.2-1.fc37.x86_64.debug liboidc-agent4-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/liboidc-agent.so.4.3.2-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/oidc-add-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/oidc-agent-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/oidc-gen-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/oidc-token-4.3.2-1.fc37.x86_64.debug oidc-agent-desktop.x86_64: W: position-independent-executable-suggested /usr/bin/oidc-prompt oidc-agent-desktop-debuginfo.x86_64: W: position-independent-executable-suggested /usr/lib/debug/usr/bin/oidc-prompt-4.3.2-1.fc37.x86_64.debug oidc-agent-cli-debuginfo.x86_64: W: no-documentation oidc-agent-debuginfo.x86_64: W: no-documentation oidc-agent-debugsource.x86_64: W: no-documentation oidc-agent-desktop-debuginfo.x86_64: W: no-documentation oidc-agent.x86_64: E: no-binary oidc-agent-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/oidc-agent-4.3.2-1.fc37.x86_64 oidc-agent-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz oidc-agent-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz oidc-agent-desktop.x86_64: W: desktopfile-without-binary /usr/share/applications/oidc-gen.desktop bash liboidc-agent4-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/ab/337ed01bb703c25d94618e56a57a6447ca87b0 ../../../.build-id/ab/337ed01bb703c25d94618e56a57a6447ca87b0 oidc-agent-cli-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/2b/7fd3e2970f25f510d39195c245ef858e6135cc ../../../.build-id/2b/7fd3e2970f25f510d39195c245ef858e6135cc oidc-agent-cli-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/5e/4bbe2d05219a458be2307bbc04c2d25243cd32 ../../../.build-id/5e/4bbe2d05219a458be2307bbc04c2d25243cd32 oidc-agent-cli-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/c7/3dd8d28adc87e6bdd2cf0214908398ec375a38 ../../../.build-id/c7/3dd8d28adc87e6bdd2cf0214908398ec375a38 oidc-agent-cli-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/ec/78b3cc779cadae8899637f962dbdd3042f8163 ../../../.build-id/ec/78b3cc779cadae8899637f962dbdd3042f8163 oidc-agent-desktop-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/84/3c93196a30a0e0dfde2d3155777cf95a1d9e77 ../../../.build-id/84/3c93196a30a0e0dfde2d3155777cf95a1d9e77 11 packages and 0 specfiles checked; 9 errors, 24 warnings, 9 badness; has taken 1.5 s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1997994 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
