https://bugzilla.redhat.com/show_bug.cgi?id=2109290 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |gotmax@e.email Flags| |fedora-review+ --- Comment #6 from Maxwell G <gotmax@e.email> --- I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors[1] - [x] %check section passes - [x] The latest release is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Add package to Koschei. - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. Thanks! [1]: golang-github-googleapis-type-adapters.spec: W: no-%build-section There's nothing to build golang-github-googleapis-type-adapters.src: W: invalid-license Apache-2.0 golang-github-googleapis-type-adapters-devel.noarch: W: invalid-license Apache-2.0 rpmlint hasn't been updated to accept SPDX identifer golang-github-googleapis-type-adapters-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/googleapis/go-type-adapters/.goipath Created by the go macros golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/CHANGELOG.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/CHANGELOG.md golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/CODE_OF_CONDUCT.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/CODE_OF_CONDUCT.md golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/CONTRIBUTING.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/CONTRIBUTING.md golang-github-googleapis-type-adapters-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/googleapis/go-type-adapters/README.md /usr/share/doc/golang-github-googleapis-type-adapters-devel/README.md This is something we should fix in golist. We don't want these files to be duplicated. This[2] is the relevant code. [1]: https://pagure.io/golist/blob/master/f/cmd/golist/golist.go#_81 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2109290 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
