[Bug 2109340] Review Request: ugrep - Faster, user-friendly, and compatible grep replacement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2109340



--- Comment #5 from Carl George 🤠 <carl@xxxxxxxxxx> ---
> SSE2 is enabled by default, however my understanding is that AVX2 and NEON are not.

>From an x86_64 build log:

checking for --disable-sse2... no
checking for --disable-avx... no

>From an aarch64 build log:

checking for --disable-sse2... no
checking for --disable-neon... no

They look to be enabled by default to me, since a flag to disable them is
available and checked for during compilation.  Since this isn't a noarch
package, each architecture-specific build of ugrep will have the features that
architecture supports.

> Rust packages seem to provide different options when intrinsics are used, se for example

Those rust packages are not doing anything different with compilation.  They
are nearly empty meta-packages that map to crate "features", which is a way to
specify optional dependencies.  The aarch64_neon and avx2_backend names are
just feature names that other rust software can depend on.

https://doc.rust-lang.org/cargo/reference/features.html
https://github.com/rusticstuff/simdutf8/blob/v0.1.4/Cargo.toml#L35
https://github.com/dalek-cryptography/curve25519-dalek/blob/3.2.1/Cargo.toml#L74

> Updated the copr package at https://copr.fedorainfracloud.org/coprs/fed500/RE-flex/ to have dynamically linked libraries:

That's great, but ugrep still doesn't have a way to link against a shared
reflex library.  Thus it is allowed by the package guidelines to leave it
bundled:  "All packages whose upstreams have no mechanism to build against
system libraries MAY opt to carry bundled libraries, but if they do, they MUST
include an indication of what they bundle."

https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2109340
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux