[Bug 2099902] Review Request: python-sphinx-design - Sphinx extension for responsive web components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2099902



--- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #5)
> Note that this depends on the build backend. I've been telling people that
> when the build backend marks it as License-File, %{pyproject_files} will
> include it marked as %license, and adding it again is redundant. This
> package apparently uses flit-core build backend and flit-core does not do
> that.

Got it.  I've added the file marked as %license.

(In reply to Karolina Surma from comment #6)
> I believe the included in the build RPM files should be also marked as
> %license:

Done.

> Out of sheer curiosity, why is html/.doctrees folder kept while .buildinfo
> removed? I mostly see both of them removed as a result of docs build.

That was an oversight, corrected.

> Semantic nit-pick: Could the documentation build take place in %build
> instead of %prep?

How on earth did that get into %prep?  It was supposed to be in %build in the
first place.  Perhaps senility is setting in.

New URLs:
Spec URL:
https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design.spec
SRPM URL:
https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design-0.2.0-3.fc37.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2099902
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux