[Bug 2097925] Review Request: cepces - Certificate Enrollment through CEP/CES

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2097925



--- Comment #16 from Andreas Schneider <asn@xxxxxxxxxx> ---
The review tool complains that %{?_smp_mflags} is not used. make is called for
selinux, maybe you can turn it on there.

Also the requires should be in the form:

Requires: %{name}%{?_isa} = %{version}-%{release}

This

  Requires:       python%{python3_pkgversion}-%{name} == %{version}
  Requires:       %{name}-certmonger == %{version}
  Requires:       %{name}-selinux == %{version}

should be:

  Requires:       python%{python3_pkgversion}-%{name}%{?_isa} =
%{version}-%{release}
  Requires:       %{name}-certmonger%{?_isa} = %{version}-%{release}
  Requires:       %{name}-selinux%{?_isa} = %{version}-%{release}

Note that there is a = to much.

Same for the certmonger subpackge. It should use

  Requires:       python%{python3_pkgversion}-%{name} == %{version}


I think that should be the last fixes. Thanks for your patience :-)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2097925
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux