[Bug 1985573] Review Request: qpress - A portable file archiver using QuickLZ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1985573

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #8 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Changes in the spec file:

--- qpress.spec.old     2022-07-14 13:20:55.219000000 +0200
+++ qpress.spec 2022-07-16 17:47:48.000000000 +0200
@@ -3,12 +3,15 @@
 Release:        %autorelease
 Summary:        A portable file archiver using QuickLZ

-License:        GPLv1 or GPLv2 or GPLv3
-URL:            http://www.quicklz.com
+License:        GPLv2
+URL:            https://www.quicklz.com
 Source0:        %{url}/%{name}-%{version}-source.zip
 Patch0:         01-include-unistd.patch

 BuildRequires:  gcc-c++
+BuildRequires:  coreutils
+
+Provides:       bundled(quicklz) = 1.4.1

 %description
 qpress is a portable file archiver using QuickLZ and designed to utilize fast
@@ -20,7 +23,7 @@

 %build
 %set_build_flags
-$CXX $CXXFLAGS -o qpress qpress.cpp aio.cpp quicklz.c utilities.cpp $LDFLAGS
-lpthread
+$CXX $CXXFLAGS -o qpress qpress.cpp aio.cpp quicklz.c utilities.cpp $LDFLAGS

 %install
 install -Dpm0755 -t %{buildroot}/%{_bindir} %{name}


$ rpmlint qpress.spec ../SRPMS/qpress-11-1.fc37.src.rpm
../RPMS/x86_64/qpress-11-1.fc37.x86_64.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

qpress.x86_64: W: no-manual-page-for-binary qpress
qpress.x86_64: W: no-documentation
========= 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness;
has taken 0.8 s ========
rpmlint is Ok.

The package builds in F37
(https://koji.fedoraproject.org/koji/taskinfo?taskID=89641580). Ok.

The package is in line with Fedora packaging guidelines.
Resolution: Package APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1985573
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux