[Bug 2107888] Review Request: vale - A syntax-aware, command-line linter for prose

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2107888

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikel@xxxxxxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mikel@xxxxxxxxxxxxxxx



--- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
Hi Marek,

Fedora builds don't have access to Internet, so all the required libraries need
to be part of Fedora.

For golang packages this means that the package is unbundled:

"At the moment golang projects packaged in Fedora SHOULD be unbundled by
default. It means projects are built from dependencies packaged in Fedora."

https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_bundled_or_unbundled

I'll recommend you to use `go2rpm` to create a package and then work on top of
that.

$ go2rpm -r github.com/errata-ai/vale

or in case you want to have static BuildRequires:

$ go2rpm -r --no-dynamic-buildrequires github.com/errata-ai/vale

Trying to build the spec generated by go2rpm, the build process reports the
following dependencies missing:

No matching package to install: 'golang(github.com/errata-ai/ini)'
No matching package to install: 'golang(github.com/errata-ai/regexp2)'
No matching package to install: 'golang(github.com/jdkato/regexp)'
No matching package to install: 'golang(github.com/jdkato/titlecase)'
No matching package to install: 'golang(github.com/pterm/pterm)'

Those should be imported first to Fedora and then go with vale. 

The spec generated by go2rpm will need some tweaking, but it's a good start to
detect missing dependencies.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2107888
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux