https://bugzilla.redhat.com/show_bug.cgi?id=2107842 --- Comment #4 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Thanks for the comments. (In reply to Miro Hrončok from comment #2) > Spec sanity: > > > %global pypi_name whatthepatch > > %global pypi_version 1.0.2 > > In my opinion, defining this on top makes the spec file harder to read > later, albeit that is my opinionated view. > > I actually prefer declaring this at the top. I have changed everything else as pointed out and have updated the SPEC and SRPM. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2107842 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
