[Bug 2107381] Review Request: btop - Modern and colorful command line resource monitor that shows usage and stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2107381



--- Comment #4 from Carl George 🤠 <carl@xxxxxxxxxx> ---
rpmlint is giving me this warning:

btop.x86_64: W: files-duplicate /usr/share/doc/btop/README.md
/usr/share/btop/README.md

The rm command needs to delete it from the buildroot, not the regular
filesystem location.

-rm -f %{_datadir}/btop/README.md
+rm -f %{buildroot}%{_datadir}/btop/README.md

=============================================================================

Running the licensecheck tool turned up a few bundled header-only libraries.  I
don't see them packaged separately in Fedora yet, so for now we can just note
them as bundled and include them in the License field.  If at some point in the
future you or another packager adds them to Fedora, you can BuildRequire them
and delete the bundled copy.

-License:        ASL 2.0
+# The entire source code is ASL 2.0 except:
+# include/robin_hood.h - MIT
+# include/widechar_width.hpp - Public Domain
+License:        ASL 2.0 and MIT and Public Domain

+Provides:       bundled(widecharwidth)
+Provides:       bundled(robin-hood-hashing) = 3.11.5

https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

=============================================================================

Optional suggestion, you can put both doc files on one line if you like.

-%doc README.md
-%doc CHANGELOG.md
+%doc README.md CHANGELOG.md


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2107381
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux