Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trousers - The open-source TCG software stack https://bugzilla.redhat.com/show_bug.cgi?id=323441 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-12 11:21 EST ------- (In reply to comment #24) > (In reply to comment #22) > > * By the way: > > - Not a big problem, however your comments > > ---------------------------------------------------------- > > %build > > %configure > > make %{?_smp_mflags} > > > > # <- FROM THIS LINE > > # $1 is the number of entries in the RPM database for the package after the > step is > > # executed. So in the post step, if $1 is 1, then this is the first time we've > been > > # installed. If its 2, we're upgrading. > > # <- TO THIS LINE > > %post > > /sbin/ldconfig > > ------------------------------------------------------------- > > is in %build section. > > Do I need to fix this then? I recomment to fix this. > > - And I usually write in the order of %prep, %build, %install, %clean, > > %pre, %post, %preun, and %postun (I am only saying my habit). > > Ok, do I need to change it then? I recomment to fix this, as this order is what rpm actually does. > > By the way, where is %clean section? > I removed it in response to your comment #13: > > > - Please remove unneeded > > [ "${RPM_BUILD_ROOT}" != "/" ] && [ -d ${RPM_BUILD_ROOT} ] && What I said is exactly ------------------------------------------------------ [ "${RPM_BUILD_ROOT}" != "/" ] && [ -d ${RPM_BUILD_ROOT} ] && ------------------------------------------------------ should be removed and I didn't say that %clean section should be removed :) > Should I put it back in the %clean section? Absolutely. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review