https://bugzilla.redhat.com/show_bug.cgi?id=1985573 --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. TODO: Add a trailing slash to URL. TODO: Consider using HTTPS schema in URL and Source0. TODO: The Source0 cannot be downloaded with command-line tools like wget. The server returns "406: Not Acceptable". Inform upstream that this discrimination hinders automation. You won't probably be able to use <https://release-monitoring.org/> service for reporting new releases to Fedora Bugzilla. Source archive (SHA512: 986754cca8bb2cdcfc7e197f7e123c6b2da90db840642a6385f14613f49f7ec6b2c18944838405fe35d5382d71fcd5d69050a036dda4c5de2e588d144e16ea6b) is original. Ok. Summary is Ok. Description verified from the home page. Ok. Found licenses: aio.cpp: GPLv1 and GPLv2 aio.hpp: GPLv1 and GPLv2 quicklz.h: GPLv1 or GPLv2 quicklz.c: GPLv1 or GPLv2 qpress.cpp: GPLv1 and GPLv2 and GPLv3 01-include-unistd.patch: GPLv2 I believe that an author meant "or" instead of "and". It would be great to confirm this assumption by asking the author and packaging the confirmation e-mail message using %license macro. FIX: Provided the assumption is correct and because all these files are compiled into a single executable, the License tag should be "GPLv2". FIX: Build-require "coreutils" (qpress.spec:26). TODO: You can remove -lpthread from the g++ command. Current glibc does not have a separate pthread library. $ rpmlint qpress.spec ../SRPMS/qpress-11-1.fc37.src.rpm ../RPMS/x86_64/qpress-11-1.fc37.x86_64.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 qpress.x86_64: W: no-manual-page-for-binary qpress qpress.x86_64: W: no-documentation ========= 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.3 s ======== rpmlint is Ok. The package builds in Fedora 37 (https://koji.fedoraproject.org/koji/taskinfo?taskID=89491525). Ok. $ rpm -qlvp ../RPMS/x86_64/qpress-11-1.fc37.x86_64.rpm -rwxr-xr-x 1 root root 70544 Jul 14 13:08 /usr/bin/qpress drwxr-xr-x 2 root root 0 Jul 14 13:08 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 14 13:08 /usr/lib/.build-id/40 lrwxrwxrwx 1 root root 26 Jul 14 13:08 /usr/lib/.build-id/40/6e66d91ee0b39692eab31bf301cf2c01cce29f -> ../../../../usr/bin/qpress File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/qpress-11-1.fc37.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.33)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libgcc_s.so.1()(64bit) 1 libgcc_s.so.1(GCC_3.0)(64bit) 1 libgcc_s.so.1(GCC_3.3.1)(64bit) 1 libstdc++.so.6()(64bit) 1 libstdc++.so.6(CXXABI_1.3.9)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.20)(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/qpress-11-1.fc37.x86_64.rpm | sort -f | uniq -c 1 qpress = 11-1.fc37 1 qpress(x86-64) = 11-1.fc37 FIX: qpress-11 bundles quicklz-1.4.1. There is a separate QuickLZ project downloadable from <http://www.quicklz.com/download.html>. Please add "Provides: bundled(quicklz) = 1.4.1" <https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling>. TODO: Consider packaging quicklz at the latest version as a dynamic library and building qpress against it. $ resolvedeps rawhide ../RPMS/x86_64/qpress-11-1.fc37.x86_64.rpm Binary dependencies are resolvable. Ok. Otherwise, this package is in line with Fedora packaging guidelines. Please correct all "FIX" items, consider fixing "TODO" items, and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1985573 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
