https://bugzilla.redhat.com/show_bug.cgi?id=2085444 Yunying Sun <yunying.sun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(xiangquan.liu@int | |el.com) | --- Comment #15 from Yunying Sun <yunying.sun@xxxxxxxxx> --- Thank you all for the reviews and comments. Updated Spec: https://yunyings.fedorapeople.org/sgx-sdk.spec Updated SRPM: https://yunyings.fedorapeople.org/sgx-sdk-2.16.100.0-1.fc35.src.rpm Updated Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=89480110 This update is trying to fix most of the issues mentioned in previous comments. Some exceptions: 1. "BuildRequires: perl" is not changed, since using "perl-base" instead leads to various build errors complaining not able to find many other perl libs like perl-FindBin/perl-lib(for lib.pm). 2. .pc and sample files are not separated to -devel and -sample subpackages. As Xiangquan said, the whole SDK is for development only, so we try to keep all within one package. Please let us know if subpackages are must-to-have. 3. After using "BuildRequires: python3-devel" instead of "python", compiling fails for can't find "python". New "BuildRequires: python-unversioned-command" is added to fix the failure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2085444 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
