https://bugzilla.redhat.com/show_bug.cgi?id=2106939 --- Comment #1 from Carl George 🤠 <carl@xxxxxxxxxx> --- rpmlint is giving this warning: dhcpdump.x86_64: W: position-independent-executable-suggested /usr/bin/dhcpdump `-fPIE` is part of the default build flags [0], so this surprised me. After some digging I realized that because this is using a simple Makefile outside of autotools, and make by itself doesn't respect exported environment variables, we need to explicitly pass the build flags (and link flags) to the make call. -%make_build +%make_build CFLAGS="%{build_cflags}" LDFLAGS="%{build_ldflags}" Another small tweak that's needed is to preserve the timestamps [1]. -install -D -m 755 -t %{buildroot}%{_bindir} %{name} -install -D -m 644 -t %{buildroot}%{_mandir}/man8/ %{name}.8 +install -D -p -m 755 -t %{buildroot}%{_bindir} %{name} +install -D -p -m 644 -t %{buildroot}%{_mandir}/man8/ %{name}.8 [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_pie [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2106939 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
