[Bug 2106611] Review Request: passt - User-mode networking daemons for virtual machines and namespaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2106611

Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #7 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> ---
> Spec URL: https://passt.top/passt/tree/contrib/fedora/passt.spec
1. The links you post as part of a Review Request should point to "plain"/"raw"
files, not HTML renditions.
2. The spec file should match the one used to build the linked SRPM, i.e. it
cannot be a template that needs filling out.

> Release:	0%{?dist}
This must start at 1, not 0.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_simple_versioning

> Group:		System Environment/Daemons
> VCS:		git://passt.top/passt
Not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

> Source:		https://passt.top/passt/snapshot/passt-HEAD.tar.xz
This link points to the latest version of passt, hence the file will change
over time.
You need to use a "static" link referring to a specific commit or git tag.

> %package    selinux
This should probably be marked as "BuildArch: noarch", otherwise you end up
with a separate passt-selinux package for each architecture.

> %build
> export CFLAGS="%{optflags}"
This is not needed. Starting with Fedora 36, this is done automatically at
start of %build and %check.
If you insist on doing this, the proper way is to use the "%set_build_flags"
macro,
which will set up not only CFLAGS, but also LDFLAGS.

> %{_mandir}/man1/passt.1.*
> %{_mandir}/man1/pasta.1.*
> %{_mandir}/man1/qrap.1.*
This wildcard can match any compression method, but will fail if the man pages
are *not compressed*.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2106611
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux