https://bugzilla.redhat.com/show_bug.cgi?id=2106445 --- Comment #3 from Alain V. <alain.vigne.14@xxxxxxxxx> --- (In reply to Jaroslav Škarvada from comment #2) > (In reply to Alain V. from comment #1) > > Unofficial Review: > > > > License: GPLv2+ > > is OK > > > > - Header files in -devel subpackage, if present. > > Note: qucs-s : /usr/share/qucs-s/xspice_cmlib/include/xspice_mathfunc.h > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/#_devel_packages > > > > Well... There is no -devel package... > > > Is it worth to create devel sub-package? I don't think so. > > > > > [!]: Large data in /usr/share should live in a noarch subpackage if package > > is arched. > > Note: Arch-ed rpms have a total of 16046080 bytes in /usr/share > > qucs-s-0.0.24-1.fc37.x86_64.rpm:16046080 > > See: > > > > https://fedoraproject.org/wiki/Packaging: > > ReviewGuidelines#Package_Review_Guidelines > > > > suggests the creation of a noarch -doc subpackage, with examples dir, and > > some docs if possible. > > ChangeLog NEWS_qucs README_qucs files are outdated (remove or install in > > -doc) > > > > But the library will remain large in /usr/share ! > > > I will probably split it to the doc subpackage. The library is essential for > the functionality, thus I think the library shouldn't be split. Agree. > > > I can co-maintain: FAS: avigne > > NP I will add you if the package gets to the Fedora. Thank you. I think this will be the "new" Qucs as https://github.com/orgs/Qucs/repositories can indicate, as well as recent https://wiki.f-si.org/index.php?title=Merging_Gnucap_and_Qucs_--_The_Why_and_How discussion. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2106445 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
