[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2106171



--- Comment #4 from Maxwell G <gotmax@e.email> ---
Sure, no problem!

(In reply to Maxwell G from comment #1)
> > %global common_description %{expand:
> > A pure python RFC3986 validator
> > }
> 
> This should end with a period.

Don't forget to fix this.

> %global srcname  rfc3986-validator
> %global slugname rfc3986_validator
> %global pkgname  python-rfc3986-validator

(I thought I brought this up in the first comment, but it looks like I forgot
to....)

I'm really not a fan of all of those *name macros. It makes the specfile harder
to read than just using the appropriate name in the appropriate place. It feels
a bit silly to define %slugname and %pkgname which are only used once. %srcname
is used multiple times, but I still think it's cleaner in this case to just use
actual name. However, that's not an actual guideline, as far as I know, so it's
really up to you.

> I didn't add checks because the tests are using another package (rfc3987) not present yet in fedora.
rfc3987 appears to be present in Fedora:
https://packages.fedoraproject.org/pkgs/python-rfc3987/python3-rfc3987/

Please also see the comments in
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-a002237477#comment-26035445
about removing pytest-runner. It's deprecated upstream, and we would like to
avoid having any more packages depend on this. If you're not comfortable
patching this out, I would appreciate if you at least created an issue
upstream.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2106171
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux