https://bugzilla.redhat.com/show_bug.cgi?id=2097799 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@xxxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Use 'perl(:VERSION) >= 5.8.1' instead of 'perl >= 0:5.008001' because the package has an epoch. FIX: Please add build-requires: coreutils - needed for macro %{_fixperms} findutils - spec file line 47 perl(Carp) - lib/B/Hooks/AtRuntime.pm:8 perl(constant) - lib/B/Hooks/AtRuntime.pm:19 perl(lib) - t/00use.t:5 perl(Exporter) - tlib/t/Util.pm:6 perl(strict) - lib/B/Hooks/AtRuntime.pm:4 perl(warnings) - lib/B/Hooks/AtRuntime.pm:3 perl(XSLoader) - lib/B/Hooks/AtRuntime.pm:6 $ rpm -qp --requires perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 ld-linux-x86-64.so.2()(64bit) 1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter::Tiny) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(parent) 1 perl(strict) 1 perl(Sub::Name) 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires FIX: Please add run-requires perl(Filter::Util::Call) - lib/B/Hooks/AtRuntime.pm:25 $ rpm -qp --provides perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq -c 1 perl(B::Hooks::AtRuntime) = 7 1 perl-B-Hooks-AtRuntime = 7-1.fc37 1 perl-B-Hooks-AtRuntime(x86-64) = 7-1.fc37 Binary provides are Ok. $ rpmlint ./perl-B-Hooks-AtRuntime* ================================= rpmlint session starts ================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 == 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s = Rpmlint is ok TODO: I think 'Build', 'META.json' and the test directory 'tlib' could be removed from %doc. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file. Resolution: Not approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2097799 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
