https://bugzilla.redhat.com/show_bug.cgi?id=2088753 --- Comment #2 from Maxwell G <gotmax@e.email> --- Your specfile looks pretty good! I just have a couple minor comments. > %{url}/archive/refs/tags/%{version}.tar.gz This should be %{url}/archive/%{version}/%{name}-%{version}.tar.gz. Source0 can also be shortened to Source if you'd like. RPM has supported automatic source file numbering since 4.15.x. > Summary: Parse Python docstrings. The Summary tag should not have a period. > %description > %{_description} Normally, you'd have the text of the description on a newline after the `%description` macro. However, ``` %global _description %{expand: Parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings.} ``` already has a leading newline, so you want it formatted as `%description %{_description}`. The same thing applies for `%description -n python3-%{srcname}`. Regarding your sponsorship, you should send an introduction email to the devel list if you haven't already[1]. [1]: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/#introduce_yourself -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2088753 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
