https://bugzilla.redhat.com/show_bug.cgi?id=2106171 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gotmax@e.email Doc Type|--- |If docs needed, set a value --- Comment #1 from Maxwell G <gotmax@e.email> --- > %global common_description %{expand: > A pure python RFC3986 validator > } This should end with a period. > %{python3_sitelib}/%{slugname}-%{version}.dist-info > %{python3_sitelib}/%{slugname}.py > %pycached %{python3_sitelib}/%{slugname}.py Why are you manually specifying the directories like this while using %pyproject_save_files? Unless this is one of the few cases where it doesn't work properly, you should replace `%files -n python3-%{srcname}` with `%files -n python3-%{srcname} -f %{pyproject_files}`. You should run unit tests in %check if possible. If that isn't practical, at least run `%pyproject_check_import` You should install the README with %doc. Suggestions ---- Conventionally, the specfile directives should be aligned to 16 characters (e.g. `Name: %{pkgname}` instead of `Name: %{pkgname}`. Source0 can be shortened to Source if you'd like. RPM has supported automatic source file numbering since 4.15.x. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2106171 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
