https://bugzilla.redhat.com/show_bug.cgi?id=2105887 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Unofficial review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/cap-0.1.0/LICENSE-APACHE.txt See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License". 8 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/rust-cap/2105887-rust- cap/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- cap-devel , rust-cap+default-devel , rust-cap+nightly-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://crates.io/api/v1/crates/cap/0.1.0/download#/cap-0.1.0.crate : CHECKSUM(SHA256) this package : dfb342bc1e95bfb9b3eb80593701657580f1606df8c5563003e6fc1cd8 f09ba1 CHECKSUM(SHA256) upstream package : dfb342bc1e95bfb9b3eb80593701657580f1606df8c5563003e6fc1cd8 f09ba1 Requires -------- rust-cap-devel (rpmlib, GLIBC filtered): cargo rust-cap+default-devel (rpmlib, GLIBC filtered): cargo crate(cap) rust-cap+nightly-devel (rpmlib, GLIBC filtered): cargo crate(cap) Provides -------- rust-cap-devel: crate(cap) rust-cap-devel rust-cap+default-devel: crate(cap/default) rust-cap+default-devel rust-cap+nightly-devel: crate(cap/nightly) rust-cap+nightly-devel Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2105887 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, Haskell, C/C++, fonts, R, Java, PHP, Python, Ocaml, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: 1) Probably azure-pipelines.yml can be removed see https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_excluding_unnecessary_files 2) Should a nightly build be provided? 3) A number of warnings that might be worth reporting upstream are generated: warning: unused attribute --> src/lib.rs:44:1 | 44 | #![allow()] | ^^^^^^^^^^^ help: remove this attribute | = note: `#[warn(unused_attributes)]` on by default = note: attribute `allow` with an empty list has no effect warning: use of deprecated associated function `std::sync::atomic::AtomicUsize::compare_and_swap `: Use `compare_exchange` or `compare_exchange_weak` instead --> src/lib.rs:105:7 | 105 | .compare_and_swap(limit_old, limit, Ordering::Relaxed) | ^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default warning: use of deprecated associated function `std::sync::atomic::AtomicUsize::compare_and_swap `: Use `compare_exchange` or `compare_exchange_weak` instead --> src/lib.rs:113:7 | 113 | .compare_and_swap(limit_old, limit, Ordering::Relaxed) | ^^^^^^^^^^^^^^^^ warning: `cap` (lib) generated 3 warnings 4) The spec file seems similar to others for Rust, not sure why the following warnings are produced: warning: File listed twice: /usr/share/cargo/registry/cap-0.1.0/LICENSE-APACHE.txt warning: File listed twice: /usr/share/cargo/registry/cap-0.1.0/LICENSE-MIT.txt warning: File listed twice: /usr/share/cargo/registry/cap-0.1.0/README.md 5) Upstream does not have any tests, so probably that section can be removed from the spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2105887 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
