https://bugzilla.redhat.com/show_bug.cgi?id=2099411 Karolina Surma <ksurma@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ksurma@xxxxxxxxxx --- Comment #5 from Karolina Surma <ksurma@xxxxxxxxxx> --- > whichever package wins out. :-) There was some discussion over Jerry's package already, so I followed with my comments there. This package would need very similar improvements as were pointed out there, namely: - license file is not marked %license (nb. there are more license files in the package - one file per each bundled icon theme) - licenses are not fully declared in the specfile (from the other specfile: sphinx_design/compiled/material* is ASL 2.0) - the bundled icon packs should be explicitly mentioned as Provides I see that tarball from PyPI doesn't contain the upstream tests. In this case I think it'd be better to take the GH's tarball and run them. Ability to catch any inconsistencies when integrating newer Sphinx is - personally for me :-) - really important. However you decide to follow up with the package (this or the other one - whatever works for you :-)), I'll be happy to review it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2099411 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
