https://bugzilla.redhat.com/show_bug.cgi?id=2042701 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #5 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > ExcludeArch: s390x > ExcludeArch: armv7hl > ExcludeArch: aarch64 > ExcludeArch: ppc64le These should be accompanied by some comment explaining whether these architectures are not supported upstream, or the program simply fails to build. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support > Source1: https://github.com/vlang/vc/archive/refs/heads/master.zip This links points to the latest commit of the "master" branch in the repository, so the contents of the archive will change over time. Please pick a specific commit and refer to that. > %description > Simple, fast, safe, compiled language for developing maintainable software. Compiles itself in <1s with zero library dependencies. Description should be wrapped to a maximum of 80 characters per line. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description > %{__unzip} %{SOURCE1} -d %{_builddir}/ > %{__tar} xvfz %{SOURCE0} -C %{_builddir}/ > ... > %{__mkdir_p} %{buildroot}{%{_libdir},%{_bindir},%{_datadir}/applications} > %{__install} -p -D -m 0755 %{_builddir}/v-%{release_build}/v %{buildroot}%{_bindir}/ Using macro forms of system executables is discouraged. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros > $CC -std=gnu11 -w -I %{_builddir}/v-%{release_build}/thirdparty/stdatomic/nix -o %{_builddir}/v-%{release_build}/v1 %{_builddir}/vc-master/v.c -lm -lpthread This ignores Fedora's %{optflags}. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags > %files > %{_bindir}/v The package must include the license text. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2042701 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
