https://bugzilla.redhat.com/show_bug.cgi?id=2104123 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two (minor) issues I just saw since this just hit the package-review mailing list: - The source package *must* be named rust-%{crate}. It seems you manually adapted the generated spec to rename it from rust-%{crate} to %{crate}. This is visible because there's still %package -n %{crate} / %files -n %{crate} leftovers - I'm not even sure if this currently works as you expect. The default layout (source package: rust-%{crate}, binary package: %{crate}) should already provide what users expect (i.e. a package named "krunvm" that they can install). This also means that you don't need to manually adapt the .spec file every time you run rust2rpm, reducing the chance for errors (like the ones that are currently in there). - You need to specify the license of the statically linked binary (i.e. the %package -n %{crate} subpackage needs a separate License tag). Looking at this crate's dependencies: https://crates.io/crates/krunvm/0.1.6/dependencies I assume not all of them are licensed ASL 2.0 (though most of them probably are "MIT or ASL 2.0"). You'll need to list the licenses of all your Rust dependencies in the .spec file and update the License tag of the %{crate} subpackage accordingly. An example can be seen here: https://src.fedoraproject.org/rpms/rust-handlebars/blob/rawhide/f/rust-handlebars.spec#_28 Since this can get unweildy for packages with lots of dependencies, I've started to move this into a separate file (which is also installed as part of the package, where users can actually see this information): https://src.fedoraproject.org/rpms/rust-fedora-update-feedback/blob/rawhide/f/rust-fedora-update-feedback.spec#_41 If you want to look at my scripts that I use to generate these lists, I can post them somewhere public. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2104123 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
