https://bugzilla.redhat.com/show_bug.cgi?id=2101458 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- The %py_provides %{py3_name} in the main package section does nothing. The %descriptioin could be longer. find_packages(exclude=["tests"]) should be offered upstream. %license LICENSE is duplicated: $ rpm -qpl --licensefiles python3-starkbank-ecdsa-2.0.3-1.fc37.noarch.rpm /usr/lib/python3.11/site-packages/starkbank_ecdsa-2.0.3.dist-info/LICENSE /usr/share/licenses/python3-starkbank-ecdsa/LICENSE >> Maybe OpenSSL should be added as a weak depends? > since OpenSSL is @system package I'm not sure about adding as weak dep? Why adding it as a weak dep? Doesn't matter if it is a @system package or not. It matters whether it is directly required by this package or not. Is it? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2101458 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
