[Bug 2050281] Review Request: python-pyABF - Python library for reading files in Axon Binary Format (ABF)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2050281



--- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Hrm, looks like there's a test failure now, probably something changed with
py3.11 or the new pytest:

=================================== FAILURES
===================================
____________________ test_findStimulusFile_foundIfPathGiven
____________________
    def test_findStimulusFile_foundIfPathGiven():
        """The user can tell pyABF where to look for stimulus files."""

        abf = pyabf.ABF(ABF_PATH, stimulusFileFolder=STIM_FOLDER)
        stimulus = abf.stimulusByChannel[0]
        waveform = stimulus.stimulusWaveform(stimulusSweep=0)

        assert isinstance(waveform, np.ndarray)
        assert not np.isnan(waveform).any()
>       assert pytest.approx(waveform[100000], 76.261)
E       AssertionError: approx() is not supported in a boolean context.
E       Did you mean: `assert a == approx(b)`?
tests/test_stimulus.py:47: AssertionError
=============================== warnings summary
===============================

Luckily, this seems to have been fixed in the code. Can you please include this
patch and see how it goes?

https://github.com/swharden/pyABF/commit/9cd568066b5ff8d6079e2d8cf8af388066cc9b79

To include the patch:

- download the patch from here:
https://github.com/swharden/pyABF/commit/9cd568066b5ff8d6079e2d8cf8af388066cc9b79.patch
- add it to git repo: `git add 9cd568066b5ff8d6079e2d8cf8af388066cc9b79.patch`
- Add it to the spec as Patch0:
https://github.com/swharden/pyABF/commit/9cd568066b5ff8d6079e2d8cf8af388066cc9b79.patch
- Add `git-core` as a new BuildRequires
- Add `-S git` to the `%autosetup` command


Cheers,
Ankur


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2050281
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux