https://bugzilla.redhat.com/show_bug.cgi?id=2090823 Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment| |review+ #1894588 Flags| | --- Comment #9 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> --- Created attachment 1894588 --> https://bugzilla.redhat.com/attachment.cgi?id=1894588&action=edit Full Review Skipping already reviewed part (full review attached) and addressed fixed. How about changing %if 0%{?enable_ocltst} BuildRequires: glew-devel %endif BuildRequires: gcc-c++ BuildRequires: libglvnd-devel to %if 0%{?enable_ocltst} BuildRequires: pkgconfig(glew) %endif BuildRequires: gcc-c++ BuildRequires: pkgconfig(opengl) If you like, use %autorelease and %autochangelog macros for Release and %changelog respectively. According the full review, the package is ready for the main repository thus APPROVED. Make sure to implement the above suggestion before importing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2090823 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
