https://bugzilla.redhat.com/show_bug.cgi?id=2103367 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value Status|NEW |POST --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- For explanation: > 1) The package has documentation, https://docs.rs/gag/latest/src/gag/lib.rs.html#1-131 is it possible to package this? Short answer: no. As you noted, the documentation built with rustdoc has all the same problems as other doc generation tools (sphinx, ruby / rdoc, etc.) in that it bundles fonts, JavaScript, etc. into them, which is typically not acceptable for a Fedora package. Additionally, there's a central location for documentation for all published Rust crates. In this case, documentation for all (also historical versions of the "gag" crate would be available at https://docs.rs/gag > 2) An empty package rust-gag+default-devel-1.0.0-1.fc37.noarch.rpm is created It's not empty, it contains RPM metadata that is required to make dependency resolution work correctly for Rust packages. > 3) File timestamps are 1 January 1970, probably due to how automated packaging from a crate works. That's probably a problem on the developer's system (i.e. they're using Windows to publish sources, or something). === Actual review: Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Since you offered review swaps, could you review https://bugzilla.redhat.com/show_bug.cgi?id=2089436 in return? This missing package blocks updates of syn, proc-macro2, etc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2103367 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
