https://bugzilla.redhat.com/show_bug.cgi?id=2102106 --- Comment #6 from jiri vanek <jvanek@xxxxxxxxxx> --- At the end it all passed for me. Weid. The pkg is good, only it have runtime issues. See another comment [!]: Package functions as described. - see innext comment [!]: %check is present and all tests pass. - check requires many non existing deps, ok to leave as it is [!]: Package uses upstream build method (ant/maven/etc.) - it is gradle, so wrap it by maven is th best what coud be done, but seems that something was not correct (see next comment) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - verified manuallly - ok - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file ADDITIONAL_LICENSE_INFO is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - ok - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/lucene See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - de-orphaning recently orpahe dpkg, shoudl be ok ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "BSD 2-Clause License Common Public License 1.0", "BSD 3-Clause License", "MIT License", "*No copyright* GNU General Public License, Version 2", "ICU License", "*No copyright* Eclipse Public License 1.0", "Common Public License 1.0", "*No copyright* Common Public License 1.0", "BSD 2-Clause License", "*No copyright* Eclipse Public License 1.0 Apache License 2.0", "Apache License 2.0", "Unicode strict", "ISC License Apache License 2.0", "Unicode strict Apache License 2.0", "*No copyright* Apache License 2.0 [generated file]", "*No copyright* MIT License Apache License 2.0", "BSD 3-Clause License Apache License 2.0". 293 files have unknown license. Detailed output of licensecheck in /home/jvanek/Desktop/2102106-lucene/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lucene- suggest [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. Java: [!]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Source checksums ---------------- https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/9.2.0/lucene-test-framework-9.2.0.pom : CHECKSUM(SHA256) this package : 8771788cc1e192c785b1f1f52fff3c2fa731a0739c8111227667fc48c6dcb149 CHECKSUM(SHA256) upstream package : 8771788cc1e192c785b1f1f52fff3c2fa731a0739c8111227667fc48c6dcb149 https://repo1.maven.org/maven2/org/apache/lucene/lucene-suggest/9.2.0/lucene-suggest-9.2.0.pom : CHECKSUM(SHA256) this package : 856c93857ddc04960baa26bd08a2812f6861f6971886ae6b6937a1144044d4b9 CHECKSUM(SHA256) upstream package : 856c93857ddc04960baa26bd08a2812f6861f6971886ae6b6937a1144044d4b9 https://repo1.maven.org/maven2/org/apache/lucene/lucene-spatial3d/9.2.0/lucene-spatial3d-9.2.0.pom : CHECKSUM(SHA256) this package : 6cbd68cc65435157b747e3d992995f12404771fc7f0633dd81cb2d97d2eaa613 CHECKSUM(SHA256) upstream package : 6cbd68cc65435157b747e3d992995f12404771fc7f0633dd81cb2d97d2eaa613 https://repo1.maven.org/maven2/org/apache/lucene/lucene-sandbox/9.2.0/lucene-sandbox-9.2.0.pom : CHECKSUM(SHA256) this package : d11f93163203c721fbc6d79fb4e704e5fe25f4518bbabc566129908ea14314e6 CHECKSUM(SHA256) upstream package : d11f93163203c721fbc6d79fb4e704e5fe25f4518bbabc566129908ea14314e6 https://repo1.maven.org/maven2/org/apache/lucene/lucene-replicator/9.2.0/lucene-replicator-9.2.0.pom : CHECKSUM(SHA256) this package : 97a01c5181d236aa7e3514a0e30bded1e543cd5b1ba4196bd6f69abf0b1c4d44 CHECKSUM(SHA256) upstream package : 97a01c5181d236aa7e3514a0e30bded1e543cd5b1ba4196bd6f69abf0b1c4d44 https://repo1.maven.org/maven2/org/apache/lucene/lucene-queryparser/9.2.0/lucene-queryparser-9.2.0.pom : CHECKSUM(SHA256) this package : 6e4d68dac37b531b0f860160f76c592b2fa20c0c1eb645aa2215d52f7ab43db6 CHECKSUM(SHA256) upstream package : 6e4d68dac37b531b0f860160f76c592b2fa20c0c1eb645aa2215d52f7ab43db6 https://repo1.maven.org/maven2/org/apache/lucene/lucene-queries/9.2.0/lucene-queries-9.2.0.pom : CHECKSUM(SHA256) this package : 5a0347883a0c30f3c332f28d1c27420e5b6cd57718e82ce1c20daff4cecd61ab CHECKSUM(SHA256) upstream package : 5a0347883a0c30f3c332f28d1c27420e5b6cd57718e82ce1c20daff4cecd61ab https://repo1.maven.org/maven2/org/apache/lucene/lucene-monitor/9.2.0/lucene-monitor-9.2.0.pom : CHECKSUM(SHA256) this package : 381bc3237682ba456da04cdff6ad9e9e7b5ffc3a2d8474f2ee61137c4ff9f490 CHECKSUM(SHA256) upstream package : 381bc3237682ba456da04cdff6ad9e9e7b5ffc3a2d8474f2ee61137c4ff9f490 https://repo1.maven.org/maven2/org/apache/lucene/lucene-misc/9.2.0/lucene-misc-9.2.0.pom : CHECKSUM(SHA256) this package : a41156c46b02774f9fc93d94dcdb5b3d9e64cf28dcf7922f4cb697044aa47b27 CHECKSUM(SHA256) upstream package : a41156c46b02774f9fc93d94dcdb5b3d9e64cf28dcf7922f4cb697044aa47b27 https://repo1.maven.org/maven2/org/apache/lucene/lucene-memory/9.2.0/lucene-memory-9.2.0.pom : CHECKSUM(SHA256) this package : a3c58a7e49051538c0a48cb02bf212cd5cf10c08847a4d71a80307e219dbb3af CHECKSUM(SHA256) upstream package : a3c58a7e49051538c0a48cb02bf212cd5cf10c08847a4d71a80307e219dbb3af https://repo1.maven.org/maven2/org/apache/lucene/lucene-luke/9.2.0/lucene-luke-9.2.0.pom : CHECKSUM(SHA256) this package : b757f8b7e31bdc9839e335cf075da71ffec2f337b536d17d495a612954e0c809 CHECKSUM(SHA256) upstream package : b757f8b7e31bdc9839e335cf075da71ffec2f337b536d17d495a612954e0c809 https://repo1.maven.org/maven2/org/apache/lucene/lucene-join/9.2.0/lucene-join-9.2.0.pom : CHECKSUM(SHA256) this package : bae3ef3dfd8d6415b5665d7f49930adc0a210464e93d6b01327bb9990f29cc58 CHECKSUM(SHA256) upstream package : bae3ef3dfd8d6415b5665d7f49930adc0a210464e93d6b01327bb9990f29cc58 https://repo1.maven.org/maven2/org/apache/lucene/lucene-highlighter/9.2.0/lucene-highlighter-9.2.0.pom : CHECKSUM(SHA256) this package : 85b819422c7d4d41a7e1f408f825b5fab44d437acb4ad1507e9b5f6d61c111e1 CHECKSUM(SHA256) upstream package : 85b819422c7d4d41a7e1f408f825b5fab44d437acb4ad1507e9b5f6d61c111e1 https://repo1.maven.org/maven2/org/apache/lucene/lucene-grouping/9.2.0/lucene-grouping-9.2.0.pom : CHECKSUM(SHA256) this package : 45fb3bac2cedef03aca0ca51e7e8637c9990198f429d7f55e5cd0101927cf5f3 CHECKSUM(SHA256) upstream package : 45fb3bac2cedef03aca0ca51e7e8637c9990198f429d7f55e5cd0101927cf5f3 https://repo1.maven.org/maven2/org/apache/lucene/lucene-facet/9.2.0/lucene-facet-9.2.0.pom : CHECKSUM(SHA256) this package : b798a116214caaf6657859e4060d98be8485e4f7a44c87535be55c938bf26d9f CHECKSUM(SHA256) upstream package : b798a116214caaf6657859e4060d98be8485e4f7a44c87535be55c938bf26d9f https://repo1.maven.org/maven2/org/apache/lucene/lucene-expressions/9.2.0/lucene-expressions-9.2.0.pom : CHECKSUM(SHA256) this package : 2390ac674d4110248f1e6f692d6c78fb76b94632a0f0a242af9aa7f85a7f65cb CHECKSUM(SHA256) upstream package : 2390ac674d4110248f1e6f692d6c78fb76b94632a0f0a242af9aa7f85a7f65cb https://repo1.maven.org/maven2/org/apache/lucene/lucene-demo/9.2.0/lucene-demo-9.2.0.pom : CHECKSUM(SHA256) this package : d01e34cf582b75fc13d022422573b55edc66c5abdaa42f92beb46ef7320d36a4 CHECKSUM(SHA256) upstream package : d01e34cf582b75fc13d022422573b55edc66c5abdaa42f92beb46ef7320d36a4 https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/9.2.0/lucene-core-9.2.0.pom : CHECKSUM(SHA256) this package : c3f248bfbb8dcd2e877ea35164cffb7fa24f357253e2659048d7a9c32ea162de CHECKSUM(SHA256) upstream package : c3f248bfbb8dcd2e877ea35164cffb7fa24f357253e2659048d7a9c32ea162de https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/9.2.0/lucene-codecs-9.2.0.pom : CHECKSUM(SHA256) this package : 76d1c41026ffd1e371d8b3aee4df9dce721a254c8ecaa7c28bcead428a2161a8 CHECKSUM(SHA256) upstream package : 76d1c41026ffd1e371d8b3aee4df9dce721a254c8ecaa7c28bcead428a2161a8 https://repo1.maven.org/maven2/org/apache/lucene/lucene-classification/9.2.0/lucene-classification-9.2.0.pom : CHECKSUM(SHA256) this package : d7e3218460b4895aaba30cb698697d9585ca6504d3e70d569992aa5662f12c7c CHECKSUM(SHA256) upstream package : d7e3218460b4895aaba30cb698697d9585ca6504d3e70d569992aa5662f12c7c https://repo1.maven.org/maven2/org/apache/lucene/lucene-benchmark/9.2.0/lucene-benchmark-9.2.0.pom : CHECKSUM(SHA256) this package : 115591a1fbf8f27034a712f67136134e51c7fcf1a1a65ef1de276a80d0859d34 CHECKSUM(SHA256) upstream package : 115591a1fbf8f27034a712f67136134e51c7fcf1a1a65ef1de276a80d0859d34 https://repo1.maven.org/maven2/org/apache/lucene/lucene-backward-codecs/9.2.0/lucene-backward-codecs-9.2.0.pom : CHECKSUM(SHA256) this package : def541137ebba53542f8952669edbf58dec353c0bb44d433fc02931e539067e3 CHECKSUM(SHA256) upstream package : def541137ebba53542f8952669edbf58dec353c0bb44d433fc02931e539067e3 https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-stempel/9.2.0/lucene-analysis-stempel-9.2.0.pom : CHECKSUM(SHA256) this package : 31eefa0afdf5bca531d77e5a14cb62355c529ad03ecd453f6283dc2a6b2e5b0c CHECKSUM(SHA256) upstream package : 31eefa0afdf5bca531d77e5a14cb62355c529ad03ecd453f6283dc2a6b2e5b0c https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-smartcn/9.2.0/lucene-analysis-smartcn-9.2.0.pom : CHECKSUM(SHA256) this package : 36d35459ae281d8fe22f7ccb3445d4d8256ee3d13c46b527def0415f823e221b CHECKSUM(SHA256) upstream package : 36d35459ae281d8fe22f7ccb3445d4d8256ee3d13c46b527def0415f823e221b https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-phonetic/9.2.0/lucene-analysis-phonetic-9.2.0.pom : CHECKSUM(SHA256) this package : 746cca2da2a6ee98afe4aaebb8aa82d88497aa27b33debda071d070a3b9b5cf1 CHECKSUM(SHA256) upstream package : 746cca2da2a6ee98afe4aaebb8aa82d88497aa27b33debda071d070a3b9b5cf1 https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-opennlp/9.2.0/lucene-analysis-opennlp-9.2.0.pom : CHECKSUM(SHA256) this package : 5f31d036e5c60b31c2d9efcc37019667bd0dbd88ae90743f048d4295975dfc21 CHECKSUM(SHA256) upstream package : 5f31d036e5c60b31c2d9efcc37019667bd0dbd88ae90743f048d4295975dfc21 https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-nori/9.2.0/lucene-analysis-nori-9.2.0.pom : CHECKSUM(SHA256) this package : 5bb262dc40e6150c769e06cece6cd052c3c0004ab1383b171f2c1fdd8bc4bd04 CHECKSUM(SHA256) upstream package : 5bb262dc40e6150c769e06cece6cd052c3c0004ab1383b171f2c1fdd8bc4bd04 https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-morfologik/9.2.0/lucene-analysis-morfologik-9.2.0.pom : CHECKSUM(SHA256) this package : c6fed176648b49465708068f876756e8362442e3bf062661dd178bb6a36b849f CHECKSUM(SHA256) upstream package : c6fed176648b49465708068f876756e8362442e3bf062661dd178bb6a36b849f https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-kuromoji/9.2.0/lucene-analysis-kuromoji-9.2.0.pom : CHECKSUM(SHA256) this package : 9c00ef07eb07bce4c5c3022f91c6f8583a29159b411a9d1fa243f15c9ebb29ba CHECKSUM(SHA256) upstream package : 9c00ef07eb07bce4c5c3022f91c6f8583a29159b411a9d1fa243f15c9ebb29ba https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-icu/9.2.0/lucene-analysis-icu-9.2.0.pom : CHECKSUM(SHA256) this package : 8d79e1bc5e523a3d65250be24fdce8ad5587ab7ca982cceeaa4eb0244bac296e CHECKSUM(SHA256) upstream package : 8d79e1bc5e523a3d65250be24fdce8ad5587ab7ca982cceeaa4eb0244bac296e https://repo1.maven.org/maven2/org/apache/lucene/lucene-analysis-common/9.2.0/lucene-analysis-common-9.2.0.pom : CHECKSUM(SHA256) this package : 8694fb5b50c6c0ac5500c58ad3ea6bce0cf6f050c26a0254226b2237968f721d CHECKSUM(SHA256) upstream package : 8694fb5b50c6c0ac5500c58ad3ea6bce0cf6f050c26a0254226b2237968f721d https://dlcdn.apache.org/lucene/java/9.2.0/lucene-9.2.0-src.tgz : CHECKSUM(SHA256) this package : 320cf7a7cd39ec1dc9126c8742c109ea598e6c3dffc56a393f6b2bcc5dbd742b CHECKSUM(SHA256) upstream package : 320cf7a7cd39ec1dc9126c8742c109ea598e6c3dffc56a393f6b2bcc5dbd742b Requires -------- lucene (rpmlib, GLIBC filtered): lucene-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem lucene-suggest (rpmlib, GLIBC filtered): (java-headless or java-17-headless) javapackages-filesystem mvn(org.apache.lucene:lucene-analysis-common) mvn(org.apache.lucene:lucene-core) Provides -------- lucene: lucene lucene-javadoc: lucene-javadoc lucene-suggest: lucene-suggest mvn(org.apache.lucene:lucene-suggest) mvn(org.apache.lucene:lucene-suggest:pom:) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2102106 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Java, Shell-api Disabled plugins: Ocaml, PHP, C/C++, R, Perl, SugarActivity, fonts, Python, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2102106 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
