https://bugzilla.redhat.com/show_bug.cgi?id=2097677 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: 4357bdc590e2db5e65808d3289b000cd376a7b56a1fe22bb9f2d839e3321fb79edab1d0cadf0a2cebdd2b00a1348b1bfc1486f2734ceee920134c42158c31838) is original. Ok. Summary verified from lib/MikroTik/API.pm. Ok. FIX: Description needs to be a sentence. Also yout text is identical to Summary. Please make it an English sentence with a full stop at the end. License verified from lib/MikroTik/API.pm, README, and Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. FIX: Build-require 'make' (perl-MikroTik-API.spec:46). FIX: Build-require 'findutils' (perl-MikroTik-API.spec:50). FIX: Build-require 'coreutils' (perl-MikroTik-API.spec:50). FIX: Do not build-require 'perl(ExtUtils::MakeMaker)'. It's nowhere used. FIX: Do not build-require 'perl(Module::Install)'. It's nowhere used. TODO: Build-require 'perl(:VERSION) >= 5.6' (Makefile.PL:1). FIX: Build-require 'perl(inc::Module::Install)' (Makefile.PL:4). FIX: Build-require 'perl(strict)' (Makefile.PL:2). FIX: Build-require 'perl(warnings)' (Makefile.PL:3). TODO: Use plain 'perl' instead of macro '%{__perl}'. TODO: Use '%make_build' instead of 'make %{?_smp_mflags}'. TODO: Use '%make_install' etc. as shown in <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker>. That will enable you to get rid of the find command, use a packaging style which is recommended by packaging guidelines, and make your package alike to other ones. TODO: Either build-require modules for optional tests (Test::Pod etc.) or delete the optional tests (t/pod.t etc.). The current packaging makes the test results dependent on a content of the build root. All tests pass. Ok. $ rpmlint perl-MikroTik-API.spec ../SRPMS/perl-MikroTik-API-2.0.1-1.fc37.src.rpm ../RPMS/noarch/perl-MikroTik-API-2.0.1-1.fc37.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 ========= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-MikroTik-API-2.0.1-1.fc37.noarch.rpm drwxr-xr-x 2 root root 0 Jun 30 14:58 /usr/share/doc/perl-MikroTik-API -rw-r--r-- 1 root root 1565 Sep 26 2019 /usr/share/doc/perl-MikroTik-API/Changes -rw-r--r-- 1 root root 2447 Dec 10 2015 /usr/share/doc/perl-MikroTik-API/README -rw-r--r-- 1 root root 5538 Jun 30 14:58 /usr/share/man/man3/MikroTik::API.3pm.gz drwxr-xr-x 2 root root 0 Jun 30 14:58 /usr/share/perl5/vendor_perl/MikroTik -rw-r--r-- 1 root root 25199 Sep 26 2019 /usr/share/perl5/vendor_perl/MikroTik/API.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-MikroTik-API-2.0.1-1.fc37.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(:VERSION) >= 5.6.0 2 perl(Carp) 2 perl(Digest::MD5) 2 perl(IO::Socket::IP) 2 perl(IO::Socket::SSL) 2 perl(Moo) 2 perl(MooX::Types::MooseLike::Base) 2 perl(namespace::autoclean) 1 perl(strict) 2 perl(Time::Out) 2 perl(Try::Tiny) 2 perl(Type::Tiny) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Do not explicitly require modules which are detected by perl-generators. I.e. all the Requires: lines except of the one for perl(:MODULE_COMPAT_... $ rpm -q --provides -p ../RPMS/noarch/perl-MikroTik-API-2.0.1-1.fc37.noarch.rpm | sort -f | uniq -c 1 perl(MikroTik::API) = 2.0.1 1 perl-MikroTik-API = 2.0.1-1.fc37 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-MikroTik-API-2.0.1-1.fc37.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F37 (https://koji.fedoraproject.org/koji/taskinfo?taskID=88918960). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' items, consider fixing 'TODO' items, and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2097677 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
