https://bugzilla.redhat.com/show_bug.cgi?id=2095974 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! ----- > The %py3_dist and description comments from https://bugzilla.redhat.com/show_bug.cgi?id=2095005#c1 also apply here. For the reasons noted in bug 2095005, I’ll opt to leave the dependencies as they are, and I’ll fix the descriptions. ----- > It might be worthwhile to note that the license is specifically the BSD 3-Clause variant in a comment above the license field so you can easily change it when we transition to SPDX license identifiers. You’re right; it’s a drop in the bucket of license files I’ll have to audit and classify, but I might as well start here. ----- > The LICENSE file is duplicated in `%{python3_sitelib}` but not automatically marked with %license. I'm not sure if this is a poetry (configuration or in general) or a pyproject-rpm-macros bug. The pyproject-rpm-macros automatically mark license files in dist-info if and only if they have been listed as “License-File” in the metadata, and this is the responsibility of the build system selected by upstream—in this case, poetry-core. However, since this metadata field is defined from PEP 639[1], which is still in draft status, support is quite uneven. - While setuptools usually “gets it right” in common cases with typically-named license files, there are still issues[2]; the result should still be manually verified with “rpm -qL -p …”; and in my opinion, we can’t really assign too much blame to Python package upstreams when setuptools’s magic doesn’t work out. - The relevant support in poetry seems to be stalled for now[3]. - In hatchling, the support is there, but upstream wants to wait to enable it until PyPI supports core metadata version 2.3[4]. - I’m not sure what the status of support in other systems like flit/flit-core is. So, overall, this is mostly at the mercy of PEP 639 finalization and the choices of various Python build system upstreams, and we can expect that a large minority of packages will still need manual %license entries and duplicate license files for the time being. ----- New Spec URL: https://music.fedorapeople.org/20220629/python-openapi-schema-validator.spec New SRPM URL: https://music.fedorapeople.org/20220629/python-openapi-schema-validator-0.2.3-1.fc36.src.rpm [1] https://peps.python.org/pep-0639/ [2] https://github.com/pypa/setuptools/issues/2739 [3] https://github.com/python-poetry/poetry/issues/1350 [4] https://github.com/pypa/hatch/issues/193 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2095974 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
