Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnxml - simple C library for parsing, writing and creating XML https://bugzilla.redhat.com/show_bug.cgi?id=374791 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-11 09:58 EST ------- For 0.18.1-4: * License - From whole tarball license check, this is licensed under GPLv2+. * Parallel make - Please support parallel make (i.e. add %{?_smp_mflags} to "make") on %build section - And please remove %?_smp_mflags from "make install" on %install section. Using parallel make on "make install" frequent fails due to install directory creating timing problem (and not %?_spm_mflags) * Dependency for -devel subpackage - Please check the dependency for -devel subpackage. %_includedir/nxml.h contains: ------------------------------------------------------------- 22 #include <curl/curl.h> 23 #include <sys/types.h> 24 #include <sys/stat.h> 25 #include <fcntl.h> 26 #include <unistd.h> 27 #include <stdarg.h> 28 #include <stdlib.h> 29 #include <string.h> 30 #include <errno.h> ------------------------------------------------------------- This means libnxml-devel should have "Requires: curl-devel". * pkgconfig file libdir - %_libdir/pkgconfig/nxml.pc contains: -------------------------------------------------------------- 3 libdir=${exec_prefix}/lib -------------------------------------------------------------- This is wrong on 64 bits architecture. * rpmlint - rpmlint complaint shows ------------------------------------------------------------- libnxml-devel.i386: E: zero-length /usr/share/doc/libnxml-devel-0.18.1/html/structnxml__namespace__t__coll__graph.map libnxml-devel.i386: E: zero-length /usr/share/doc/libnxml-devel-0.18.1/html/struct____nxml__entity__t__coll__graph.map -------------------------------------------------------------- If these files are not needed, please remove these. * Timestamps - Please try to use --------------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" --------------------------------------------------------------- to keep timestamps on installed files (here installed header files). While sometimes this does not work, this way usually works for recent Makefiles. * %doc - IMO ---------------------------------------------------------------- %files devel %doc test/ ---------------------------------------------------------------- is better than "%doc test/*" to hide all test code under test/ directory from the top documents directory (%_defaultdocdir/%name-%version) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review