https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the unofficial review, Benson. Here are my (not completely satisfactory) answers to your questions. (In reply to Benson Muite from comment #2) > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file LICENSE is not marked as %license > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/LicensingGuidelines/#_license_text When the python dist-info is assembled, it includes the LICENSE file. You can see it in the binary RPM under this path: /usr/lib/python3.10/site-packages/sphinx_design-0.2.0.dist-info/LICENSE Miro has been telling people that adding the license file under %license as well is redundant, so I left it out of this package. However, it should be included in the docs subpackage. I will fix that. > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 2088960 bytes in 61 files. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_documentation ??? There is a python-sphinx-design-docs package, exactly the one that contains 61 files, in fact. > [!]: License file installed when any subpackage combination is installed. This will be fixed in the next version. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. It is documented, in the comment just above the License field. > [!]: Package contains no bundled libraries without FPC exception. I am unaware of any bundled libraries. Which ones did you find? > 1) Material icons seem to be available as a package > https://src.fedoraproject.org/rpms/material-icons-fonts but are bundled with > this > installation. Can the material-icons-fonts package be updated so that > bundling is not needed? Yes, and I'm even the maintainer of that package. :-) Here's the thing: the JSON versions of the icons are not in the source package. There are SVG icons in the source package that appear to be the source of the data in the JSON icons in this package. I assume that there is some SVG-to-JSON converter, but I know very little about fonts and certainly do not know anything about such a tool. The font guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/) say that the SVG icons are not to be installed, but do give latitude for installing JSON files. If anybody reading this knows what to do, we can modify the material-icons-fonts package to include the JSON files and unbundle them from this package. In that case, I would also be willing to package octicons and do the same unbundling. Even better would be if somebody who knows what they are doing submits octicons for review. :-) > 2) Material icons are under Apache Software License Yes, the comment above the License field says so. > 3) Documentation contains javascript files which may also have different > licenses Good point. I will add a comment above the License field in the docs subpackage. > 4) License file seems not to be packaged See explanation above. > 5) Can octicons https://github.com/primer/octicons be packaged separately > instead of using a bundled library? If the SVG-to-JSON hurdle can be overcome, then yes. > 6) Timestamps are preserved for documentation, but not for the python files The spec file uses the approved python macro, %pyproject_install, to do the installation. If it doesn't preserve timestamps when it should, that is out of my hands. > 7) Why not use tox to run the tests? > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tox Because it doesn't seem to do anything. This runs with no noticeable delay: ``` + /usr/bin/python3 -m tox --current-env -q --recreate -e py311 ___________________________________ summary ____________________________________ py311: commands succeeded congratulations :) ``` as opposed to using %pytest, which takes several seconds and prints meaningful output. New URLs (although that doesn't matter, since this bug is closed): Spec URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design.spec SRPM URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design-0.2.0-2.fc37.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2099902 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
