[Bug 2101580] Review Request: rust-pwd - Safe interface to pwd.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2101580



--- Comment #4 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
(In reply to Fabio Valentini from comment #3)
> It appears you have linked a .spec file from an SRPM that was already
> mangled by rpmautospec. That's usually not a good idea for a package review,
> and using a preprocessed SRPM file like that will also cause creation of a
> corrupted / broken .spec file when using "fedpkg import".
> 
yeah, in this case I think the original spec in fedorapeople.org is better.
Looks like fedora-create-review choked before actually uploading it though.

> > # FIXME: Upstream uses unknown SPDX tag CC-PDDC!
> 
> Usually FIXME items should be addressed before submitting a package for
> review. ;)
> 
> In this instance, this license (CC-PDDC / Creative Commons Public Domain
> Dedication and Certification) is neither considered "free" by the FSF nor is
> it an OSI-approved license according its listing on the SPDX website.
> 
> It is also not the Fedora list of "good" licenses, either (though similar
> licenses are). You will need to inquire with Fedora legal whether this
> license can be considered acceptable, and if it can be added to the list of
> "good" licenses before this package can be imported.

That's... problematic. We should see if this is a hard dependency of nu-path or
not, and double check with upstream.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2101580
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux