https://bugzilla.redhat.com/show_bug.cgi?id=2097267 --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Benson, thank you for the preliminary review. It looks like we mostly found the same things. (In reply to Benson Muite from comment #3) > Unofficial Review: > > […] > > Comments: > 1) Can you check that this builds on Copr/Koji for at least x86_64,AARCH64 > and ARM_hfp? A scratch-build wouldn’t hurt, although it would be very unusual if there were any architecture-dependent issues in a noarch, pure-Ruby package. ARM_hfp is not required in general since https://fedoraproject.org/wiki/Changes/RetireARMv7. Arched packages targeting releases older than Rawhide will still need to be compatible or ExcludeArch, of course. Here is a scratch build for Rawhide that forces the package to build on all current architectures (rather than any arbitrary architecture, as would be normal for a noarch package): $ koji build --scratch --arch-override='x86_64 i686 ppc64le s390x aarch64' f37 rubygem-ast-tdl-0.0.2-1.fc34.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=88654518 Normally I wouldn’t ask for that on a noarch package review, although there are indeed some cases where it could find a problem. > 4) Packaged does not seem to preserve timestamps, but this maybe common with > Rubygems I didn’t notice this; thanks. Once the gem is built and %gem_installed in %build, the installation in %install uses “cp -a”, which does preserve timestamps—it’s just the original source timestamps were lost in %build. I think this is OK since the package follows the templates in the Ruby packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2097267 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
