https://bugzilla.redhat.com/show_bug.cgi?id=2097925 --- Comment #5 from Ding-Yi Chen <dchen@xxxxxxxxxx> --- (In reply to Andreas Schneider from comment #3) > It should be two lines: > > install -d -m 0755 path/to/dir > > install -m 0644 source dest > install -m 0644 source dest > > This way you set correct permissions to the directory and also files. Um, currently it looks like ~~~ for SELINUXVARIANT in %{selinux_variants}; do install -d %{buildroot}%{_datadir}/selinux/${SELINUXVARIANT} install -p -m 644 selinux/%{name}-${SELINUXVARIANT}.pp \ %{buildroot}%{_datadir}/selinux/${SELINUXVARIANT}/%{name}.pp echo %{_datadir}/selinux/${SELINUXVARIANT}/%{name}.pp >> \ selinux-files.txt done # Rename configuration files. mv %{buildroot}%{_sysconfdir}/%{name}/cepces.conf{.dist,} mv %{buildroot}%{_sysconfdir}/%{name}/logging.conf{.dist,} ~~~ Should I change it to: ~~~ for SELINUXVARIANT in %{selinux_variants}; do install -d -m 0755 %{buildroot}%{_datadir}/selinux/${SELINUXVARIANT} install -m 644 selinux/%{name}-${SELINUXVARIANT}.pp \ %{buildroot}%{_datadir}/selinux/${SELINUXVARIANT}/%{name}.pp echo %{_datadir}/selinux/${SELINUXVARIANT}/%{name}.pp >> \ selinux-files.txt done # Rename configuration files. install -d -m 0755 %{buildroot}%{_sysconfdir}/%{name}/ install -m 644 %{buildroot}%{_sysconfdir}/%{name}/cepces.conf{.dist,} rm -f %{buildroot}%{_sysconfdir}/%{name}/cepces.conf.dist install -m 644 %{buildroot}%{_sysconfdir}/%{name}/logging.conf{.dist,} rm -f %{buildroot}%{_sysconfdir}/%{name}/logging.conf.dist ~~~ Or you mean I should rename *.conf.dist to *.conf; change setup.py to use *.conf instead of *.conf.dist and we don't need to rename them in installation stage? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2097925 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
